Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: appengine/findit/model/crash/test/crash_analysis_test.py

Issue 2067373002: [Findit] Add fracas analysis result feedback page for manual triage. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@only-dashboard
Patch Set: Merge branch 'only-dashboard' into dashboard Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/model/crash/crash_analysis.py ('k') | appengine/findit/model/triage_status.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/model/crash/test/crash_analysis_test.py
diff --git a/appengine/findit/model/crash/test/crash_analysis_test.py b/appengine/findit/model/crash/test/crash_analysis_test.py
index 42cf2306e3b4be565652b82e47a2f5623085f3f1..1255d9b12f5d1bf8fd2f28e9c3a4618c0a72fa43 100644
--- a/appengine/findit/model/crash/test/crash_analysis_test.py
+++ b/appengine/findit/model/crash/test/crash_analysis_test.py
@@ -69,26 +69,9 @@ class CrashAnalysisTest(unittest.TestCase):
self.assertIsNone(analysis.found_suspects)
self.assertIsNone(analysis.solution)
- def testResultCorrect(self):
+ def testUpdate(self):
analysis = CrashAnalysis()
- result_properties = ['suspected_cls', 'suspected_project',
- 'suspected_components', 'regression_range']
-
- analysis.status = analysis_status.ERROR
- for result_property in result_properties:
- self.assertIsNone(analysis.ResultCorrect(result_property))
-
- analysis.status = analysis_status.COMPLETED
- for result_property in result_properties:
- setattr(analysis, '%s_triage_status' % result_property,
- triage_status.TRIAGED_CORRECT)
- self.assertTrue(analysis.ResultCorrect(result_property))
- setattr(analysis, '%s_triage_status' % result_property,
- triage_status.TRIAGED_INCORRECT)
- self.assertFalse(analysis.ResultCorrect(result_property))
- setattr(analysis, '%s_triage_status' % result_property,
- triage_status.TRIAGED_UNSURE)
- self.assertIsNone(analysis.ResultCorrect(result_property))
- setattr(analysis, '%s_triage_status' % result_property,
- triage_status.UNTRIAGED)
- self.assertIsNone(analysis.ResultCorrect(result_property))
+ update = {'note': 'this is a note. +2314>?'}
+ analysis.Update(update)
+ for key, value in update.iteritems():
+ self.assertEqual(getattr(analysis, key), value)
« no previous file with comments | « appengine/findit/model/crash/crash_analysis.py ('k') | appengine/findit/model/triage_status.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698