chrome/browser/android/password_ui_view_android.cc - Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/password_ui_view_android.cc

Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/preferences/password/PasswordReauthenticationFragmentTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/password_ui_view_android.cc

diff --git a/chrome/browser/android/password_ui_view_android.cc b/chrome/browser/android/password_ui_view_android.cc

index 84db6852ef21c9405f5de5463859a6d62ce85511..6c1336c3c8b7184b0cbda7aa4563724a456e6cb9 100644

--- a/chrome/browser/android/password_ui_view_android.cc

+++ b/chrome/browser/android/password_ui_view_android.cc

@@ -111,12 +111,14 @@ ScopedJavaLocalRef<jobject> PasswordUIViewAndroid::GetSavedPasswordEntry(

return Java_PasswordUIView_createSavedPasswordEntry(

env,

ConvertUTF8ToJavaString(env, std::string()).obj(),

+ ConvertUTF16ToJavaString(env, base::string16()).obj(),

ConvertUTF16ToJavaString(env, base::string16()).obj());

}

std::string human_readable_origin = GetDisplayOriginForSettings(*form);

return Java_PasswordUIView_createSavedPasswordEntry(

env, ConvertUTF8ToJavaString(env, human_readable_origin).obj(),

- ConvertUTF16ToJavaString(env, form->username_value).obj());

+ ConvertUTF16ToJavaString(env, form->username_value).obj(),

+ ConvertUTF16ToJavaString(env, form->password_value).obj());

}

ScopedJavaLocalRef<jstring> PasswordUIViewAndroid::GetSavedPasswordException(