chrome/android/java/res/layout/password_entry_editor_interactive.xml - Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/password_entry_editor_interactive.xml

Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/password_entry_editor.xml ('k') | chrome/android/java/res/layout/password_reauthentication_container.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/password_entry_editor_interactive.xml

diff --git a/chrome/android/java/res/layout/password_entry_editor_interactive.xml b/chrome/android/java/res/layout/password_entry_editor_interactive.xml

index 3e43d500a0e4e1edbc9ffa9fdc50a303af655da3..ef69ef249e07f59aa273e03e48495099e8e68c91 100644

--- a/chrome/android/java/res/layout/password_entry_editor_interactive.xml

+++ b/chrome/android/java/res/layout/password_entry_editor_interactive.xml

@@ -45,7 +45,9 @@

android:layout_weight="1" />

<ImageButton

+ android:id="@+id/password_entry_editor_copy_site"

style="?android:attr/buttonStyleSmall"

+ android:background="@null"

android:layout_width="match_parent"

android:layout_height="wrap_content"

android:layout_gravity="end"

@@ -87,7 +89,9 @@

android:layout_weight="1" />

<ImageButton

+ android:id="@+id/password_entry_editor_copy_username"

style="?android:attr/buttonStyleSmall"

+ android:background="@null"

android:layout_width="match_parent"

android:layout_height="wrap_content"

android:layout_gravity="end"

@@ -119,6 +123,7 @@

android:layout_height="wrap_content"

android:layout_marginTop="10dp"

android:layout_marginStart="15dp"

+ android:inputType="textPassword"

android:textAppearance="?android:attr/textAppearanceMedium" />

<View

@@ -127,6 +132,8 @@

android:layout_weight="1" />

<ImageButton

+ android:id="@+id/password_entry_editor_view_password"

+ android:background="@null"

style="?android:attr/buttonStyleSmall"

android:layout_width="match_parent"

android:layout_height="wrap_content"

@@ -137,6 +144,8 @@

android:contentDescription="@string/password_entry_editor_view_stored_password" />

<ImageButton

+ android:id="@+id/password_entry_editor_copy_password"

+ android:background="@null"

style="?android:attr/buttonStyleSmall"

android:layout_width="match_parent"

android:layout_height="wrap_content"