Allow copying and viewing account credentials in PasswordEntryEditor

chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
index 27a1e58e70519d956456dae6fd85e6d267ed35a1..f7b268cf36c36d6f84d4eeeaa97a128b8f31ae4d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
@@ -45,6 +45,7 @@ public class SavePasswordsPreferences extends PreferenceFragment
     // Keys for name/password dictionaries.
     public static final String PASSWORD_LIST_URL = "url";
     public static final String PASSWORD_LIST_NAME = "name";
+    public static final String PASSWORD_LIST_PASSWORD = "password";
 
     // Used to pass the password id into a new activity.
     public static final String PASSWORD_LIST_ID = "id";
@@ -73,6 +74,17 @@ public class SavePasswordsPreferences extends PreferenceFragment
     private ChromeSwitchPreference mSavePasswordsSwitch;
     private ChromeBaseCheckBoxPreference mAutoSignInSwitch;
 
+    // Used for verifying if 60 seconds have passed since last authenticating.

[vabr (Chromium), 2016/08/17 08:57:42]

nit: Could you please also comment about what exactly the value is? I suppose it
is the time since the Unix epoch in milliseconds, but not sure if that's
correct.

[dozsa, 2016/08/17 10:40:27]

Done.

+    private static long sLastReauthTimeMillis = 0;
+
+    public static void setLastReauthTimeMillis(long value) {
+        sLastReauthTimeMillis = value;
+    }
+
+    public static long getLastReauthTimeMillis() {
+        return sLastReauthTimeMillis;
+    }
+
     @Override
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
@@ -111,6 +123,12 @@ public class SavePasswordsPreferences extends PreferenceFragment
         return true;
     }
 
+    @Override
+    public void onDetach() {

[vabr (Chromium), 2016/08/17 08:57:42]

This is worth testing, e.g., by:
(1) creating SavePasswordPreferences
(2) setting the last reauth time to some non-zero value
(3) destroying the SavePasswordPreferences
(4) re-creating SavePasswordPreferences
(5) checking that the last reauth time is zero

[dozsa, 2016/08/17 10:40:27]

Acknowledged.

+        super.onDetach();
+        sLastReauthTimeMillis = 0;
+    }
+
     void rebuildPasswordLists() {
         mNoPasswords = false;
         mNoPasswordExceptions = false;
@@ -154,12 +172,14 @@ public class SavePasswordsPreferences extends PreferenceFragment
             PreferenceScreen screen = getPreferenceManager().createPreferenceScreen(getActivity());
             String url = saved.getUrl();
             String name = saved.getUserName();
+            String password = saved.getPassword();
             screen.setTitle(url);
             screen.setOnPreferenceClickListener(this);
             screen.setSummary(name);
             Bundle args = screen.getExtras();
             args.putString(PASSWORD_LIST_NAME, name);
             args.putString(PASSWORD_LIST_URL, url);
+            args.putString(PASSWORD_LIST_PASSWORD, password);
             args.putInt(PASSWORD_LIST_ID, i);
             profileCategory.addPreference(screen);
         }