Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chrome/android/java/res/layout/password_entry_editor_interactive.xml

Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Solve comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/password_entry_editor_interactive.xml
diff --git a/chrome/android/java/res/layout/password_entry_editor_interactive.xml b/chrome/android/java/res/layout/password_entry_editor_interactive.xml
index 4b5540160f013c40c98133371bfe205d8d9c8f18..ef69ef249e07f59aa273e03e48495099e8e68c91 100644
--- a/chrome/android/java/res/layout/password_entry_editor_interactive.xml
+++ b/chrome/android/java/res/layout/password_entry_editor_interactive.xml
@@ -13,8 +13,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="vertical"
- android:title="@string/password_entry_editor_title"
- android:visibility="gone">
+ android:title="@string/password_entry_editor_title">
<TextView
android:text="@string/password_entry_editor_site_title"
@@ -46,7 +45,9 @@
android:layout_weight="1" />
<ImageButton
+ android:id="@+id/password_entry_editor_copy_site"
style="?android:attr/buttonStyleSmall"
+ android:background="@null"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="end"
@@ -88,7 +89,9 @@
android:layout_weight="1" />
<ImageButton
+ android:id="@+id/password_entry_editor_copy_username"
style="?android:attr/buttonStyleSmall"
+ android:background="@null"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="end"
@@ -120,6 +123,7 @@
android:layout_height="wrap_content"
android:layout_marginTop="10dp"
android:layout_marginStart="15dp"
+ android:inputType="textPassword"
android:textAppearance="?android:attr/textAppearanceMedium" />
<View
@@ -128,6 +132,8 @@
android:layout_weight="1" />
<ImageButton
+ android:id="@+id/password_entry_editor_view_password"
+ android:background="@null"
style="?android:attr/buttonStyleSmall"
android:layout_width="match_parent"
android:layout_height="wrap_content"
@@ -138,6 +144,8 @@
android:contentDescription="@string/password_entry_editor_view_stored_password" />
<ImageButton
+ android:id="@+id/password_entry_editor_copy_password"
+ android:background="@null"
style="?android:attr/buttonStyleSmall"
android:layout_width="match_parent"
android:layout_height="wrap_content"

Powered by Google App Engine
This is Rietveld 408576698