Allow copying and viewing account credentials in PasswordEntryEditor

chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordReauthentication.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordReauthentication.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordReauthentication.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordReauthentication.java
new file mode 100644
index 0000000000000000000000000000000000000000..84799e9279671d95e20d5931cfb2222b430ca457
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordReauthentication.java
@@ -0,0 +1,71 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.preferences.password;
+
+import android.annotation.TargetApi;
+import android.app.Fragment;
+import android.app.FragmentManager;
+import android.app.KeyguardManager;
+import android.content.Context;
+import android.content.Intent;
+import android.os.Build;
+import android.os.Build.VERSION_CODES;
+import android.os.Bundle;
+import android.widget.LinearLayout;
+
+import org.chromium.chrome.R;
+
+/** Show the lock screen confirmation and lock the screen. */
+public class PasswordReauthentication extends Fragment {
+
+    private static final int CONFIRM_DEVICE_CREDENTIAL_REQUEST_CODE = 2;
+
+    private LinearLayout mLayout;
+
+    @Override
+    public void onCreate(Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+        lockDeviceOnLollipop();
+    }
+
+    @Override
+    public void onActivityResult(int requestCode, int resultCode, Intent data) {
+        super.onActivityResult(requestCode, resultCode, data);
+        if (requestCode == CONFIRM_DEVICE_CREDENTIAL_REQUEST_CODE) {
+            if (resultCode == getActivity().RESULT_OK) {
+                SavePasswordsPreferences.setLastReauthTimeMillis(System.currentTimeMillis());
+                FragmentManager fragmentManager = getFragmentManager();
+                fragmentManager.popBackStack();
+            }
+        }
+    }
+
+    /**
+     * Should only be called on Lollipop or above devices.
+     */
+    @TargetApi(VERSION_CODES.LOLLIPOP)
+    private void lockDeviceOnLollipop() {
+        // Use new L feature to lock screen.
+        if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.LOLLIPOP) {
+            throw new IllegalStateException("Must be called on L+ devices");

[Bernhard Bauer, 2016/08/03 12:54:42]

So we'll just crash on pre-L devices? o_O

[dozsa, 2016/08/03 14:06:54]

Sorry, I meant to replace this with a text announcing that users can't view/copy
passwords if their devices are pre-Lollipop. One of Vaclav's earlier comments
was "There might have been some confusion about this, but I don't think we need
to
implement this for pre-Lollipop. The number of affected users will decrease with
time, and we can add it later if there is a need for it. If dropping this would
make the code simpler, I'd suggest focussing just on Lollipop+." Should I look
into implementing this on pre-Lollipop devices as well?

+        }
+        KeyguardManager keyguardManager = (KeyguardManager)
+                getActivity().getSystemService(Context.KEYGUARD_SERVICE);
+        if (keyguardManager != null) {
+            Intent intent = keyguardManager.createConfirmDeviceCredentialIntent(null /* title */,
+                    getString(R.string.lockscreen_description) /* description */);
+            if (intent != null) {
+                startActivityForResult(intent, CONFIRM_DEVICE_CREDENTIAL_REQUEST_CODE);
+                return;
+            } else {

[Bernhard Bauer, 2016/08/03 12:54:42]

"Else" isn't necessary after a return statement. Then you could just fall
through to the else branch in the outer if statement.

[dozsa, 2016/08/03 14:06:54]

Done.

+                FragmentManager fragmentManager = getFragmentManager();
+                fragmentManager.popBackStackImmediate();
+            }
+        } else {
+            FragmentManager fragmentManager = getFragmentManager();
+            fragmentManager.popBackStackImmediate();
+        }
+    }
+}