Allow copying and viewing account credentials in PasswordEntryEditor

chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
index 4e818500012fee1e1e5f8f608e09fcc79644a4b3..100ca3616472cf1e398188e908e8410b7a320518 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
@@ -50,8 +50,19 @@ public class MainPreferences extends PreferenceFragment implements SignInStateOb
     private SignInPreference mSignInPreference;
     private ManagedPreferenceDelegate mManagedPreferenceDelegate;
 
+    // Used for verifying if 60 seconds have passed since last authenticating.

[vabr (Chromium), 2016/07/28 09:44:33]

So is it 60 or 30 seconds? The comment here and the design doc say 60, the code
in the patch says 30. It looks like we should stick to what the design doc says
(or change the design if there are good reasons for doing so).

Note that the desktop implementation uses 60 seconds.
https://cs.chromium.org/chromium/src/chrome/browser/ui/passwords/password_man...

[dozsa, 2016/07/28 14:00:32]

Sorry, I think I changed it to 30 seconds for testing purposes. I've changed it
back to 60.

+    private static long sStartTime = 0;
+
     private boolean mShowSearchEnginePicker;
 
+    public static void setStartTime(long value) {
+        sStartTime = value;
+    }
+
+    public static long getStartTime() {
+        return sStartTime;
+    }
+
     public MainPreferences() {
         setHasOptionsMenu(true);
         mManagedPreferenceDelegate = createManagedPreferenceDelegate();
@@ -101,6 +112,7 @@ public class MainPreferences extends PreferenceFragment implements SignInStateOb
     }
 
     private void updatePreferences() {
+        sStartTime = 0;

[vabr (Chromium), 2016/07/28 09:44:33]

If you made sStartTime a (non-static) data member of SavePasswordsPreferences,
could you then use the constructor of SavePasswordsPreferences to reset it? That
would allow you to keep MainPreferences out of this, which seems fair, given
that the timeout is only relevant for passwords.

Or is the problem that SavePasswordsPreferences is not destroyed on hiding?

[dozsa, 2016/07/28 14:00:32]

The latter isn't a problem, so I've moved sStartTime to
SavePasswordsPreferences. 

         if (getPreferenceScreen() != null) getPreferenceScreen().removeAll();
         addPreferencesFromResource(R.xml.main_preferences);