Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2067223005: Remove unnecessary MemberHash<> templates. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary MemberHash<> templates. Directly define the hash traits of all heap reference template types (Member<T> - or Persistent<T>-derived) in terms of MemberHash<T>, and avoid introducing ad-hoc templates for these. Add missing (CrossThread)WeakPersistent<T> hash traits also. R= BUG= Committed: https://crrev.com/95d55a4f8ca7f2088cd31cba4b0cba2643e94f84 Cr-Commit-Position: refs/heads/master@{#400155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M third_party/WebKit/Source/platform/heap/Member.h View 3 chunks +3 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-16 12:32:29 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-16 14:39:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067223005/1
4 years, 6 months ago (2016-06-16 15:04:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 15:07:54 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 15:07:55 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 15:09:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95d55a4f8ca7f2088cd31cba4b0cba2643e94f84
Cr-Commit-Position: refs/heads/master@{#400155}

Powered by Google App Engine
This is Rietveld 408576698