Parameterize Ash unittests to pass with material design enabled

ash/test/ash_md_test_base.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/test/ash_md_test_base.h"
+
+namespace ash {
+namespace test {
+
+AshMDTestBase::AshMDTestBase()
+    : md_maximized_window_height_offset_(0) {

[James Cook, 2016/06/16 16:08:56]

nit: init in header

[tdanderson, 2016/06/21 19:52:21]

Can you clarify what you mean here? Inlining a ctor looks to be forbidden by our
style guide, and assigning a value of 0 on line 34 seems a bit strange to do.

[James Cook, 2016/06/21 22:17:54]

I mean "int md_maximized_window_height_offset_ = 0;" in the header. Given that
there is no complex initialization going on here, initializing in the header
puts the default value closer to the declaration and makes it easier to see that
all POD members are initialized.

[tdanderson, 2016/06/22 16:51:55]

Done.

+}
+
+AshMDTestBase::~AshMDTestBase() {
+}
+
+void AshMDTestBase::SetUp() {
+  test::AshTestBase::SetUp();
+  material_design_state_.reset(
+      new test::MaterialDesignControllerTestAPI(GetParam()));
+  md_maximized_window_height_offset_ =
+      ash::MaterialDesignController::IsMaterial() ? -1 : 0;

[James Cook, 2016/06/16 16:08:56]

optional: maybe compute this based on the constants themselves? or at least
reference them in a comment?

[tdanderson, 2016/06/21 19:52:21]

This is a great idea, done.

+}
+
+void AshMDTestBase::TearDown() {
+  material_design_state_.reset();
+  test::AshTestBase::TearDown();
+}
+
+int AshMDTestBase::GetMdMaximizedWindowHeightOffset() {
+  return md_maximized_window_height_offset_;
+}
+
+}  // namespace test
+}  // namespace ash