Source/core/css/resolver/StyleResolver.h - Issue 20672003: Avoid reaching for StyleResolver::m_features from StyleBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleResolver.h

Issue 20672003: Avoid reaching for StyleResolver::m_features from StyleBuilder. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleResolver.h

diff --git a/Source/core/css/resolver/StyleResolver.h b/Source/core/css/resolver/StyleResolver.h

index 3c5a8b3927b51331ee1207faf1209d702d63b299..b6778dffbcfdce6357d05fac2be2cf4f7eee3dec 100644

--- a/Source/core/css/resolver/StyleResolver.h

+++ b/Source/core/css/resolver/StyleResolver.h

@@ -344,6 +344,8 @@ private:

ScopedStyleTree m_styleTree;

+ // FIXME: The entire logic of collecting features on StyleResolver, as well astransferring them

+ // between various parts of machinery smells wrong. This needs to be better somehow.

RuleFeatureSet m_features;

OwnPtr<RuleSet> m_siblingRuleSet;

OwnPtr<RuleSet> m_uncommonAttributeRuleSet;