Avoid reaching for StyleResolver::m_features from StyleBuilder.

Avoid reaching for StyleResolver::m_features from StyleBuilder.

In order to inform style invalidation machinery, we have to keep track
of all styles that depend on DOM state. This bookkeeping is provided
by RuleFeatureSet, which is unfortunately hosted on StyleResolver.

This means that whenever we apply a "content: attr(foo)" property,
we must reach for m_features and add stuff to it.

This change avoids direct reaching by accumulating values on StyleResolverState.

No change in behavior, so no tests.

BUG=259085
R=eae, eseidel, esprehn

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155382

[eseidel, 2013-08-01 20:07:11]

lgtm

When I was looking at this, my approach was to make more of RuleFeatureSet
private and add methods.  That forced me to stare at all the callers.

I suspect we'll want to accumulate out parameters on these methods and then
union them into the features.  I guess that's what you're doing here, although
I'm not sure I see the full vision.

lgtm.  please continue iterating. :)

[commit-bot: I haz the power, 2013-08-01 20:07:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dglazkov@chromium.org/20672003/1

[dglazkov, 2013-08-01 20:09:30]

On 2013/08/01 20:07:11, eseidel wrote:

> I suspect we'll want to accumulate out parameters on these methods and then
> union them into the features.  I guess that's what you're doing here, although
> I'm not sure I see the full vision.

This is actually a yak shave for unhinging StyleBuilder from StyleResolver,
which in itself is a yak shave for enabling using StyleBuilder instead of
StyleResolver in FontLoader and HTMLCanvasElement, which in itself is a yak
shave for enabling FontBuilder to actually construct a Font :D

[commit-bot: I haz the power, 2013-08-02 04:34:54]

Change committed as 155382