Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: tools/telemetry/telemetry/core/wpr_server.py

Issue 20672002: [telemetry] Add a webdriver backend with support for IE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/wpr_server.py
diff --git a/tools/telemetry/telemetry/core/wpr_server.py b/tools/telemetry/telemetry/core/wpr_server.py
index 6904d98506c18a1a2eeb2dd6e5256a7b90fd7aa2..31c1b4b57551961db739b8d12881e3689db0c858 100644
--- a/tools/telemetry/telemetry/core/wpr_server.py
+++ b/tools/telemetry/telemetry/core/wpr_server.py
@@ -53,6 +53,8 @@ class ReplayServer(object):
self._webpagereplay_local_http_port,
self._webpagereplay_local_https_port,
options)
+ if browser_backend.webdriver_based:
nduca 2013/07/30 06:49:45 lets do this by constructing the options list firs
chrisgao (Use stgao instead) 2013/07/31 19:05:41 Good idea. Done. But we need to override webpagere
+ self._web_page_replay.replay_options.remove('--no-dns_forwarding')
self._web_page_replay.StartServer()
def __enter__(self):

Powered by Google App Engine
This is Rietveld 408576698