tools/telemetry/telemetry/core/chrome/cros_browser_backend.py - Issue 20672002: [telemetry] Add a webdriver backend with support for IE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

Issue 20672002: [telemetry] Add a webdriver backend with support for IE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/chrome/browser_backend.py ('K') | « tools/telemetry/telemetry/core/chrome/browser_backend.py ('k') | tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py » ('j') | tools/telemetry/telemetry/core/webdriver/webdriver_browser_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

index 2ede95dfb249858fe4c1cdfd06848ed208894705..78e2f9fb26d8cdab809cab93ec507d836ed11f4e 100644

--- a/tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

@@ -228,7 +228,7 @@ class CrOSBrowserBackend(browser_backend.BrowserBackend):

def CreateForwarder(self, *port_pairs):

assert self._cri

- return (browser_backend.DoNothingForwarder(*port_pairs) if self._cri.local

+ return (util.DoNothingForwarder(*port_pairs) if self._cri.local

else SSHForwarder(self._cri, 'R', *port_pairs))

def _RestartUI(self):