Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: tools/telemetry/telemetry/core/wpr_server.py

Issue 20672002: [telemetry] Add a webdriver backend with support for IE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/wpr_server.py
diff --git a/tools/telemetry/telemetry/core/wpr_server.py b/tools/telemetry/telemetry/core/wpr_server.py
index 6904d98506c18a1a2eeb2dd6e5256a7b90fd7aa2..0a9d6c684ddd34c15225584ca07c7c18525a46e6 100644
--- a/tools/telemetry/telemetry/core/wpr_server.py
+++ b/tools/telemetry/telemetry/core/wpr_server.py
@@ -17,6 +17,17 @@ import webpagereplay # pylint: disable=F0401
def GetChromeFlags(replay_host, http_port, https_port):
return webpagereplay.GetChromeFlags(replay_host, http_port, https_port)
+class _WebPageReplayServer(webpagereplay.ReplayServer): # pylint: disable=W0232
+ def _AddDefaultReplayOptions(self):
+ """Override.Because '--no-dns_forwarding' is added by default in parent
chrisgao (Use stgao instead) 2013/07/31 19:05:41 "Override.Because" -> "Override. Because"
chrisgao (Use stgao instead) 2013/08/01 00:36:44 Done in https://codereview.chromium.org/21406004/.
+ while webdriver-based backends need dns forwarding."""
+ self.replay_options += [
+ '--port', str(self._http_port),
+ '--ssl_port', str(self._https_port),
+ '--use_closest_match',
+ '--log_level', 'warning'
+ ]
+
class ReplayServer(object):
def __init__(self, browser_backend, path, is_record_mode, is_append_mode,
make_javascript_deterministic, webpagereplay_host,
@@ -47,7 +58,8 @@ class ReplayServer(object):
options.append('--record')
if not make_javascript_deterministic:
options.append('--inject_scripts=')
- self._web_page_replay = webpagereplay.ReplayServer(
+ browser_backend.CustomizeReplayServerWithOptions(options)
+ self._web_page_replay = _WebPageReplayServer(
path,
self._webpagereplay_host,
self._webpagereplay_local_http_port,

Powered by Google App Engine
This is Rietveld 408576698