tools/telemetry/telemetry/core/wpr_server.py - Issue 20672002: [telemetry] Add a webdriver backend with support for IE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/wpr_server.py

Issue 20672002: [telemetry] Add a webdriver backend with support for IE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/webdriver/webdriver_tab_backend.py ('K') | « tools/telemetry/telemetry/core/webdriver/webdriver_tab_list_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/wpr_server.py

diff --git a/tools/telemetry/telemetry/core/wpr_server.py b/tools/telemetry/telemetry/core/wpr_server.py

index 6904d98506c18a1a2eeb2dd6e5256a7b90fd7aa2..244082c70d025f06cd6c881b987ffe54894d88ab 100644

--- a/tools/telemetry/telemetry/core/wpr_server.py

+++ b/tools/telemetry/telemetry/core/wpr_server.py

@@ -53,6 +53,8 @@ class ReplayServer(object):

self._webpagereplay_local_http_port,

self._webpagereplay_local_https_port,

options)

+ if browser_backend.browser_type.startswith('webdriver.'):

tonyg 2013/07/26 18:21:07 I don't think it is good for the wpr_server to exp

chrisgao (Use stgao instead) 2013/07/30 02:06:49 Done as discussed offline.

+ self._web_page_replay.replay_options.remove('--no-dns_forwarding')

self._web_page_replay.StartServer()

def __enter__(self):