Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2067183003:
Use WeakPtr in HotwordService Constructor to ensure that invokes to InitializeMicrophoneObserver ca… (Closed)
|
Created:
4 years, 6 months ago by xiaoyinh(OOO Sep 11-29) Modified:
4 years, 6 months ago CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse WeakPtr to ensure automatic cancellation of tasks.
Use WeakPtr in HotwordService Constructor to ensure that,
invokes to InitializeMicrophoneObserver cannot outlive HotwordService Object.
BUG=617332
TEST=Unit Tests
Committed: https://crrev.com/4a66954b1826d4fde1b4eae316f4512be17a0a02
Cr-Commit-Position: refs/heads/master@{#400196}
Patch Set 1 #
Messages
Total messages: 19 (8 generated)
xiaoyinh@chromium.org changed reviewers: + amistry@chromium.org, kcarattini@chromium.org, mgiuca@chromium.org
LGTM Keep in mind, this may not fix the ubsan issue. My analysis was just a suspicion based on staring at the code a little bit.
On 2016/06/15 21:57:13, Anand Mistry wrote: > LGTM > > Keep in mind, this may not fix the ubsan issue. My analysis was just a suspicion > based on staring at the code a little bit. Thanks Anand. I've tested with this fix that the failures are no longer reproducible following the steps in bug 617332 comment3.
lgtm Please change the CL description so the first line is <72 characters (and a complete sentence), giving further detail if necessary in the following paragraph.
CFI trybot is green, hurrah!
Description was changed from ========== Use WeakPtr in HotwordService Constructor to ensure that invokes to InitializeMicrophoneObserver can not outlive HotwordService Object BUG=617332 TEST=Unit Tests ========== to ========== Use WeakPtr to ensure automatic cancellation of tasks. Use WeakPtr in HotwordService Constructor to ensure that invokes to InitializeMicrophoneObserver cannot outlive HotwordService Object. BUG=617332 TEST=Unit Tests ==========
Description was changed from ========== Use WeakPtr to ensure automatic cancellation of tasks. Use WeakPtr in HotwordService Constructor to ensure that invokes to InitializeMicrophoneObserver cannot outlive HotwordService Object. BUG=617332 TEST=Unit Tests ========== to ========== Use WeakPtr to ensure automatic cancellation of tasks. Use WeakPtr in HotwordService Constructor to ensure that, invokes to InitializeMicrophoneObserver cannot outlive HotwordService Object. BUG=617332 TEST=Unit Tests ==========
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067183003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaoyinh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067183003/1
Message was sent while issue was closed.
Description was changed from ========== Use WeakPtr to ensure automatic cancellation of tasks. Use WeakPtr in HotwordService Constructor to ensure that, invokes to InitializeMicrophoneObserver cannot outlive HotwordService Object. BUG=617332 TEST=Unit Tests ========== to ========== Use WeakPtr to ensure automatic cancellation of tasks. Use WeakPtr in HotwordService Constructor to ensure that, invokes to InitializeMicrophoneObserver cannot outlive HotwordService Object. BUG=617332 TEST=Unit Tests ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use WeakPtr to ensure automatic cancellation of tasks. Use WeakPtr in HotwordService Constructor to ensure that, invokes to InitializeMicrophoneObserver cannot outlive HotwordService Object. BUG=617332 TEST=Unit Tests ========== to ========== Use WeakPtr to ensure automatic cancellation of tasks. Use WeakPtr in HotwordService Constructor to ensure that, invokes to InitializeMicrophoneObserver cannot outlive HotwordService Object. BUG=617332 TEST=Unit Tests Committed: https://crrev.com/4a66954b1826d4fde1b4eae316f4512be17a0a02 Cr-Commit-Position: refs/heads/master@{#400196} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4a66954b1826d4fde1b4eae316f4512be17a0a02 Cr-Commit-Position: refs/heads/master@{#400196}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
