components/offline_pages/offline_page_client_policy.h - Issue 2067143004: [Offline Pages] Duplicate pages when save/delete bookmarks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/offline_page_client_policy.h

Issue 2067143004: [Offline Pages] Duplicate pages when save/delete bookmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/offline_pages/client_policy_controller.cc ('K') | « components/offline_pages/client_policy_controller.cc ('k') | components/offline_pages/offline_page_model_impl.h » ('j') | components/offline_pages/offline_page_model_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_CLIENT_POLICY_H_	5 #ifndef COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_CLIENT_POLICY_H_

6 #define COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_CLIENT_POLICY_H_	6 #define COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_CLIENT_POLICY_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include <string>	10 #include <string>

(...skipping 30 matching lines...) Expand all Loading...
41	41

42 // The struct describing policies for various namespaces (Bookmark, Last-N etc.)	42 // The struct describing policies for various namespaces (Bookmark, Last-N etc.)

43 // used by offline page model. The name_space is supposed to be key, so that	43 // used by offline page model. The name_space is supposed to be key, so that

44 // it's sufficient to compare name_space only when doing comparisons.	44 // it's sufficient to compare name_space only when doing comparisons.

45 struct OfflinePageClientPolicy {	45 struct OfflinePageClientPolicy {

46 // Namespace to which the policy applied.	46 // Namespace to which the policy applied.

47 std::string name_space;	47 std::string name_space;

48	48

49 // Policy to control the lifetime of a page generated by this namespace.	49 // Policy to control the lifetime of a page generated by this namespace.

50 LifetimePolicy lifetime_policy;	50 LifetimePolicy lifetime_policy;

	51

	52 // How many pages are allowed for an URL.
	Dmitry Titov 2016/06/23 04:23:15 It looks the comment can be made clearer - how abo It looks the comment can be made clearer - how about "How many pages for the same online URL can be stored at any time"? romax 2016/06/23 22:24:03 Done. Show quoted text On 2016/06/23 04:23:15, Dmitry Titov wrote: > It looks the comment can be made clearer - how about "How many pages for the > same online URL can be stored at any time"? Done.
	53 size_t pages_allowed_per_url;

51 };	54 };

52	55

53 } // namespace offline_pages	56 } // namespace offline_pages

54	57

55 #endif // COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_CLIENT_POLICY_H_	58 #endif // COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_CLIENT_POLICY_H_

OLD	NEW