Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2067133003: Add android_sdk asset (Closed)

Created:
4 years, 6 months ago by borenet2
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@assets
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add android_sdk asset BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067133003

Patch Set 1 #

Patch Set 2 : Remove old Android SDK isolation stuff #

Patch Set 3 : Rebase #

Patch Set 4 : +x #

Total comments: 2

Patch Set 5 : Rebase, update #

Patch Set 6 : Experiment: shrink download_asset.isolate #

Patch Set 7 : Experiment #

Patch Set 8 : Experiment #

Patch Set 9 : Experiment: Fix infra/bots paths #

Patch Set 10 : Experiment #2 #

Patch Set 11 : Add create* scripts for android-sdk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -145 lines) Patch
D infra/bots/android_sdk.isolate View 1 1 chunk +0 lines, -7 lines 0 comments Download
D infra/bots/android_sdk_hash View 1 1 chunk +0 lines, -1 line 0 comments Download
A infra/bots/assets/android_sdk/VERSION View 1 chunk +1 line, -0 lines 0 comments Download
A + infra/bots/assets/android_sdk/common.py View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/android_sdk/create.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +39 lines, -0 lines 0 comments Download
A + infra/bots/assets/android_sdk/create_and_upload.py View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -1 line 0 comments Download
A + infra/bots/assets/android_sdk/download.py View 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/android_sdk/upload.py View 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M infra/bots/assets/asset_utils.py View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -4 lines 0 comments Download
M infra/bots/assets/asset_utils_test.py View 1 2 3 4 5 6 7 8 1 chunk +1 line, -2 lines 0 comments Download
M infra/bots/download_asset.isolate View 1 2 3 4 5 6 8 9 1 chunk +9 lines, -4 lines 0 comments Download
D infra/bots/isolate_android_sdk.py View 1 1 chunk +0 lines, -129 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
borenet
Patch set 1 was created like this: $ python infra/bots/assets/assets.py add android_sdk $ python infra/bots/assets/android_sdk/upload.py ...
4 years, 6 months ago (2016-06-15 10:31:25 UTC) #2
borenet
Depends on https://codereview.chromium.org/2069543002/ and https://codereview.chromium.org/2068123002/
4 years, 6 months ago (2016-06-15 13:19:32 UTC) #4
rmistry
lgtm https://codereview.chromium.org/2067133003/diff/60001/infra/bots/assets/android_sdk/VERSION File infra/bots/assets/android_sdk/VERSION (right): https://codereview.chromium.org/2067133003/diff/60001/infra/bots/assets/android_sdk/VERSION#newcode1 infra/bots/assets/android_sdk/VERSION:1: 0 [Optional] Should version numbers start at 1? ...
4 years, 6 months ago (2016-06-15 13:53:24 UTC) #5
borenet
https://codereview.chromium.org/2067133003/diff/60001/infra/bots/assets/android_sdk/VERSION File infra/bots/assets/android_sdk/VERSION (right): https://codereview.chromium.org/2067133003/diff/60001/infra/bots/assets/android_sdk/VERSION#newcode1 infra/bots/assets/android_sdk/VERSION:1: 0 On 2016/06/15 13:53:24, rmistry wrote: > [Optional] Should ...
4 years, 6 months ago (2016-06-15 19:56:13 UTC) #6
rmistry
On 2016/06/15 19:56:13, borenet wrote: > https://codereview.chromium.org/2067133003/diff/60001/infra/bots/assets/android_sdk/VERSION > File infra/bots/assets/android_sdk/VERSION (right): > > https://codereview.chromium.org/2067133003/diff/60001/infra/bots/assets/android_sdk/VERSION#newcode1 > ...
4 years, 6 months ago (2016-06-15 20:16:38 UTC) #7
borenet
Shrunk the input isolate, fixed some resulting path issues.
4 years, 6 months ago (2016-06-16 07:52:57 UTC) #8
rmistry
lgtm
4 years, 6 months ago (2016-06-16 12:34:52 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067133003/200001
4 years, 6 months ago (2016-06-16 20:21:47 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 20:51:31 UTC) #13
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698