Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2067133002: Add test for rendering an already abandoned texture-backed SkImage. (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 6 months ago
Reviewers:
junov1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add test for rendering an already abandoned texture-backed SkImage. BUG=chromium:618858 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067133002 Committed: https://skia.googlesource.com/skia/+/e5b651f94cff565969fd064330c72c51b2ff0b4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tests/ImageTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
4 years, 6 months ago (2016-06-15 02:55:35 UTC) #3
egdaniel
lgtm
4 years, 6 months ago (2016-06-15 13:54:17 UTC) #4
Justin Novosad
On 2016/06/15 13:54:17, egdaniel wrote: > lgtm FWIW, The case that is currently crashing is ...
4 years, 6 months ago (2016-06-15 13:58:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067133002/1
4 years, 6 months ago (2016-06-15 13:58:41 UTC) #7
bsalomon
On 2016/06/15 13:58:09, Justin Novosad wrote: > On 2016/06/15 13:54:17, egdaniel wrote: > > lgtm ...
4 years, 6 months ago (2016-06-15 14:13:07 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 14:36:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e5b651f94cff565969fd064330c72c51b2ff0b4c

Powered by Google App Engine
This is Rietveld 408576698