Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/native_library_mac.mm

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use std::string directly. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/native_library.h ('K') | « base/native_library.h ('k') | base/native_library_posix.cc » ('j') | chrome/browser/load_library_perf_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/native_library_mac.mm
diff --git a/base/native_library_mac.mm b/base/native_library_mac.mm
index 6544fcaed99eaf644bd36da96bdd864e8bd39327..c2d94fe6595c8f99ceed909aa9865d942fb0b8be 100644
--- a/base/native_library_mac.mm
+++ b/base/native_library_mac.mm
@@ -42,8 +42,9 @@ static NativeLibraryObjCStatus GetObjCStatusForImage(
}
// static
+// TODO(xhwang): Fill |error|. See http://crbug.com/353771
NativeLibrary LoadNativeLibrary(const base::FilePath& library_path,
- std::string* error) {
+ NativeLibraryLoadError* /* error */) {
// dlopen() etc. open the file off disk.
if (library_path.Extension() == "dylib" || !DirectoryExists(library_path)) {
void* dylib = dlopen(library_path.value().c_str(), RTLD_LAZY);
« base/native_library.h ('K') | « base/native_library.h ('k') | base/native_library_posix.cc » ('j') | chrome/browser/load_library_perf_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698