base/native_library_mac.mm - Issue 206713004: Report PPAPI plugin load error code to UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/native_library_mac.mm

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments addressed Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/native_library_mac.mm

diff --git a/base/native_library_mac.mm b/base/native_library_mac.mm

index 6544fcaed99eaf644bd36da96bdd864e8bd39327..275570749c382bf697063954904a14898707fa23 100644

--- a/base/native_library_mac.mm

+++ b/base/native_library_mac.mm

@@ -43,7 +43,8 @@ static NativeLibraryObjCStatus GetObjCStatusForImage(

// static

NativeLibrary LoadNativeLibrary(const base::FilePath& library_path,

- std::string* error) {

+ std::string* /* error_message */,

+ uint32* /* error_code */) {

// dlopen() etc. open the file off disk.

if (library_path.Extension() == "dylib" || !DirectoryExists(library_path)) {

void* dylib = dlopen(library_path.value().c_str(), RTLD_LAZY);