Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: mojo/shell/in_process_dynamic_service_runner.cc

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: BASE_EXPORT Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/app_child_process.cc ('k') | third_party/libjingle/overrides/init_webrtc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/in_process_dynamic_service_runner.cc
diff --git a/mojo/shell/in_process_dynamic_service_runner.cc b/mojo/shell/in_process_dynamic_service_runner.cc
index 62ca5e3445cd17e7eb043b3e22ce02c3d698f72d..9030d59927604cc4c33d5795f78e63f661217603 100644
--- a/mojo/shell/in_process_dynamic_service_runner.cc
+++ b/mojo/shell/in_process_dynamic_service_runner.cc
@@ -54,11 +54,12 @@ void InProcessDynamicServiceRunner::Run() {
base::Bind(base::IgnoreResult(&base::DeleteFile), app_path_, false));
do {
- std::string load_error;
+ base::NativeLibraryLoadError error;
base::ScopedNativeLibrary app_library(
- base::LoadNativeLibrary(app_path_, &load_error));
+ base::LoadNativeLibrary(app_path_, &error));
if (!app_library.is_valid()) {
- LOG(ERROR) << "Failed to load library (error: " << load_error << ")";
+ LOG(ERROR) << "Failed to load library (error: " << error.ToString()
+ << ")";
break;
}
« no previous file with comments | « mojo/shell/app_child_process.cc ('k') | third_party/libjingle/overrides/init_webrtc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698