Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: base/native_library_posix.cc

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make NativeLibraryLoadError a class. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/native_library_posix.cc
diff --git a/base/native_library_posix.cc b/base/native_library_posix.cc
index dfa20fc01cf78ef6ab2061f3eefb32d3c8f324c0..256a651edd6cce9b1cb63983fa304521a974472f 100644
--- a/base/native_library_posix.cc
+++ b/base/native_library_posix.cc
@@ -4,6 +4,8 @@
#include "base/native_library.h"
+#include <ostream>
+
#include <dlfcn.h>
#include "base/files/file_path.h"
@@ -15,7 +17,7 @@ namespace base {
// static
NativeLibrary LoadNativeLibrary(const FilePath& library_path,
- std::string* error) {
+ NativeLibraryLoadError* error) {
// dlopen() opens the file off disk.
base::ThreadRestrictions::AssertIOAllowed();
@@ -25,7 +27,7 @@ NativeLibrary LoadNativeLibrary(const FilePath& library_path,
// and http://crbug.com/40794.
void* dl = dlopen(library_path.value().c_str(), RTLD_LAZY);
if (!dl && error)
- *error = dlerror();
+ error->message = dlerror();
return dl;
}
@@ -50,4 +52,10 @@ string16 GetNativeLibraryName(const string16& name) {
return ASCIIToUTF16("lib") + name + ASCIIToUTF16(".so");
}
+// static
+std::ostream& operator<<(std::ostream& out,
+ const NativeLibraryLoadError& error) {
+ return out << error.message;
+}
+
} // namespace base

Powered by Google App Engine
This is Rietveld 408576698