Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: base/native_library.h

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/native_library_mac.mm » ('j') | base/native_library_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/native_library.h
diff --git a/base/native_library.h b/base/native_library.h
index d7513d0b050e181b4df913e276b39051aef5318f..51105492794b70191f7f92ce16fe446b17ed21f1 100644
--- a/base/native_library.h
+++ b/base/native_library.h
@@ -54,7 +54,8 @@ typedef void* NativeLibrary;
// you're done. Returns NULL on failure.
// If |error| is not NULL, it may be filled in with an error message on error.
ddorwin 2014/03/20 22:01:12 Similar comment for error_code. We might specifica
xhwang 2014/03/21 01:42:58 Done.
BASE_EXPORT NativeLibrary LoadNativeLibrary(const FilePath& library_path,
- std::string* error);
+ std::string* error_message,
+ uint32* error_code = NULL);
xhwang 2014/03/20 21:40:03 This optional parameter is just trying to avoid up
#if defined(OS_WIN)
// Loads a native library from disk. Release it with UnloadNativeLibrary when
« no previous file with comments | « no previous file | base/native_library_mac.mm » ('j') | base/native_library_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698