Report PPAPI plugin load error code to UMA.

content/ppapi_plugin/ppapi_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/ppapi_plugin/ppapi_thread.h"
 
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/cpu.h"
@@ skipping 251 matching lines @@
     if (plugins[i].is_internal && plugins[i].path == path) {
       // An internal plugin is being loaded, so fetch the entry points.
       plugin_entry_points_ = plugins[i].internal_entry_points;
     }
   }
 
   // If the plugin isn't internal then load it from |path|.
   base::ScopedNativeLibrary library;
   if (plugin_entry_points_.initialize_module == NULL) {
     // Load the plugin from the specified library.
-    std::string error;
-    library.Reset(base::LoadNativeLibrary(path, &error));
+    std::string error_message;
+    uint32 error_code = 0;
+    library.Reset(base::LoadNativeLibrary(path, &error_message, &error_code));
     if (!library.is_valid()) {
       LOG(ERROR) << "Failed to load Pepper module from "
-        << path.value() << " (error: " << error << ")";
+        << path.value() << " (error: " << error_message << " with error code "

[ddorwin, 2014/03/20 22:01:12]

nit: You could also do something like "error 'code' - 'message'"

[xhwang, 2014/03/21 01:42:58]

Done.

+        << error_code << ")";
       ReportLoadResult(path, LOAD_FAILED);
+      // Report detailed reason for load failure.
+      ReportLoadErrorCode(path, error_code);
       return;
     }
 
     // Get the GetInterface function (required).
     plugin_entry_points_.get_interface =
         reinterpret_cast<PP_GetInterface_Func>(
             library.GetFunctionPointer("PPP_GetInterface"));
     if (!plugin_entry_points_.get_interface) {
       LOG(WARNING) << "No PPP_GetInterface in plugin library";
       ReportLoadResult(path, ENTRY_POINT_MISSING);
@@ skipping 224 matching lines @@
       base::LinearHistogram::FactoryGet(
           histogram_name.str(),
           1,
           LOAD_RESULT_MAX,
           LOAD_RESULT_MAX + 1,
           base::HistogramBase::kUmaTargetedHistogramFlag);
 
   histogram->Add(result);
 }
 
+void PpapiThread::ReportLoadErrorCode(const base::FilePath& path,
+                                      uint32 error_code) {
+  // See http://msdn.microsoft.com/en-us/library/ms681381.aspx

[ddorwin, 2014/03/20 22:01:12]

This is based on only Win reporting an error code. That should probably be
mentioned, along with some type of DCHECK that error_code < kMaxLoadErrorCode or
error_code==0 if not OS_WIN.

[xhwang, 2014/03/21 01:42:58]

Not required since we use sparse histogram.

+  static const uint32 kMaxLoadErrorCode = 16000;
+
+  std::ostringstream histogram_name;
+  histogram_name << "Plugin.Ppapi" << (is_broker_ ? "Broker" : "Plugin")
+                 << "LoadErrorCode_" << path.BaseName().MaybeAsASCII();
+
+  // Note: This leaks memory, which is expected behavior.
+  base::HistogramBase* histogram =
+      base::LinearHistogram::FactoryGet(

[ddorwin, 2014/03/20 22:01:12]

Should this be sparse?

[xhwang, 2014/03/21 01:42:58]

Good point. Done.

+          histogram_name.str(),
+          1,
+          kMaxLoadErrorCode,
+          kMaxLoadErrorCode + 1,
+          base::HistogramBase::kUmaTargetedHistogramFlag);
+
+  histogram->Add(error_code);
+}
+
 }  // namespace content