Report PPAPI plugin load error code to UMA.

base/native_library.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_NATIVE_LIBRARY_H_
 #define BASE_NATIVE_LIBRARY_H_
 
 // This file defines a cross-platform "NativeLibrary" type which represents
 // a loadable module.
 
@@ skipping 34 matching lines @@
     void* dylib;
   };
 };
 typedef NativeLibraryStruct* NativeLibrary;
 #elif defined(OS_POSIX)
 typedef void* NativeLibrary;
 #endif  // OS_*
 
 // Loads a native library from disk.  Release it with UnloadNativeLibrary when
 // you're done.  Returns NULL on failure.
 // If |error| is not NULL, it may be filled in with an error message on error.

[ddorwin, 2014/03/20 22:01:12]

Similar comment for error_code. We might specifically mention "if the platform
supports it."

[xhwang, 2014/03/21 01:42:58]

Done.

 BASE_EXPORT NativeLibrary LoadNativeLibrary(const FilePath& library_path,
-                                            std::string* error);
+                                            std::string* error_message,
+                                            uint32* error_code = NULL);

[xhwang, 2014/03/20 21:40:03]

This optional parameter is just trying to avoid update all other call sites
(>10) in this prototype CL. I'll either update all call sites with NULL
|error_code|, or add a new function in this file, e.g.
LoadNativeLibraryAndReportError(). Let me know which one you prefer.

 
 #if defined(OS_WIN)
 // Loads a native library from disk.  Release it with UnloadNativeLibrary when
 // you're done.
 // This function retrieves the LoadLibrary function exported from kernel32.dll
 // and calls it instead of directly calling the LoadLibrary function via the
 // import table.
 BASE_EXPORT NativeLibrary LoadNativeLibraryDynamically(
     const FilePath& library_path);
 #endif  // OS_WIN
 
 // Unloads a native library.
 BASE_EXPORT void UnloadNativeLibrary(NativeLibrary library);
 
 // Gets a function pointer from a native library.
 BASE_EXPORT void* GetFunctionPointerFromNativeLibrary(NativeLibrary library,
                                                       const char* name);
 
 // Returns the full platform specific name for a native library.
 // For example:
 // "mylib" returns "mylib.dll" on Windows, "libmylib.so" on Linux,
 // "mylib.dylib" on Mac.
 BASE_EXPORT string16 GetNativeLibraryName(const string16& name);
 
 }  // namespace base
 
 #endif  // BASE_NATIVE_LIBRARY_H_