Fixing Toolbar flakiness in Android client.

Fixing Toolbar flakiness in Android client.

This change addresses the problems that some users have been seeing in
the auto-hiding toolbar in our Android app.  The auto-hide behavior
appears to work correctly until the user brings up the soft keyboard.
At this point the toolbar might be hidden but attempts to display the
toolbar again will fail.

We rely on System UI visibility events being fired to tell us when to
show or hide the Toolbar and in some cases these are not firing
consistently which is the root cause of the issues above.

This CL changes the way in which we update the System UI visibility when
the soft keyboard is displayed.  I removed the old logic which would
hide the ToolBar and System UI (and rely on the underlying OS to finish
hiding the System UI when the keyboard was dismissed) and moved it to
our Keyboard detection method.  Now we only hide the ActionBar when the
auto-hide timer fires and the soft keyboard is present and only call to
hide the System UI once the soft keyboard is dismissed.

This also solves a usability problem we had previously where the call to
hide the System UI would cause it to turn transparent which made finding
the dismiss KB button difficult when it was rendered over a white
background.

I've also added a method which is used when we resume the app which
checks the current System UI state and updates the ActionBar visibility
(and timer) to match.  This fixes some behavior I saw bring the app back
from a stopped state where the System UI and ActionBar were out of sync.

BUG=618388
Committed: https://crrev.com/e9707b3db49ad29d458932a5940d5df10ff14416
Cr-Commit-Position: refs/heads/master@{#399980}

[joedow, 2016-06-15 04:00:06]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 04:00:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067093002/40001

[commit-bot: I haz the power, 2016-06-15 04:21:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 04:21:32]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-06-15 15:55:17]

joedow@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[joedow, 2016-06-15 15:55:18]

PTAL!

Thanks,
Joe

[Lambros, 2016-06-15 18:47:17]

lgtm

[joedow, 2016-06-15 18:57:46]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-06-15 18:58:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067093002/60001

[commit-bot: I haz the power, 2016-06-15 19:03:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-15 19:04:08]

Description was changed from

==========
Fixing Toolbar flakiness in Android client.

This change addresses the problems that some users have been seeing in
the auto-hiding toolbar in our Android app.  The auto-hide behavior
appears to work correctly until the user brings up the soft keyboard.
At this point the toolbar might be hidden but attempts to display the
toolbar again will fail.

We rely on System UI visibility events being fired to tell us when to
show or hide the Toolbar and in some cases these are not firing
consistently which is the root cause of the issues above.

This CL changes the way in which we update the System UI visibility when
the soft keyboard is displayed.  I removed the old logic which would
hide the ToolBar and System UI (and rely on the underlying OS to finish
hiding the System UI when the keyboard was dismissed) and moved it to
our Keyboard detection method.  Now we only hide the ActionBar when the
auto-hide timer fires and the soft keyboard is present and only call to
hide the System UI once the soft keyboard is dismissed.

This also solves a usability problem we had previously where the call to
hide the System UI would cause it to turn transparent which made finding
the dismiss KB button difficult when it was rendered over a white
background.

I've also added a method which is used when we resume the app which
checks the current System UI state and updates the ActionBar visibility
(and timer) to match.  This fixes some behavior I saw bring the app back
from a stopped state where the System UI and ActionBar were out of sync.

BUG=618388
==========

to

==========
Fixing Toolbar flakiness in Android client.

This change addresses the problems that some users have been seeing in
the auto-hiding toolbar in our Android app.  The auto-hide behavior
appears to work correctly until the user brings up the soft keyboard.
At this point the toolbar might be hidden but attempts to display the
toolbar again will fail.

We rely on System UI visibility events being fired to tell us when to
show or hide the Toolbar and in some cases these are not firing
consistently which is the root cause of the issues above.

This CL changes the way in which we update the System UI visibility when
the soft keyboard is displayed.  I removed the old logic which would
hide the ToolBar and System UI (and rely on the underlying OS to finish
hiding the System UI when the keyboard was dismissed) and moved it to
our Keyboard detection method.  Now we only hide the ActionBar when the
auto-hide timer fires and the soft keyboard is present and only call to
hide the System UI once the soft keyboard is dismissed.

This also solves a usability problem we had previously where the call to
hide the System UI would cause it to turn transparent which made finding
the dismiss KB button difficult when it was rendered over a white
background.

I've also added a method which is used when we resume the app which
checks the current System UI state and updates the ActionBar visibility
(and timer) to match.  This fixes some behavior I saw bring the app back
from a stopped state where the System UI and ActionBar were out of sync.

BUG=618388

Committed: https://crrev.com/e9707b3db49ad29d458932a5940d5df10ff14416
Cr-Commit-Position: refs/heads/master@{#399980}
==========

[commit-bot: I haz the power, 2016-06-15 19:04:10]

Patchset 4 (id:??) landed as
https://crrev.com/e9707b3db49ad29d458932a5940d5df10ff14416
Cr-Commit-Position: refs/heads/master@{#399980}