Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2067073002: media: Run mojo media application in GPU process on desktop by default (Closed)

Created:
4 years, 6 months ago by xhwang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Run mojo media application in GPU process on desktop by default When "enable_mojo_media" is enabled (which is disabled by default on desktop), we'll host the mojo media application in the gpu process and have "video_decoder" service enabled. This will be used to test and support the mojo video decoder service. For the CDM service on desktop, since the CDM doesn't need to talk to any other mojo services (it will be called directly by the media pipeline in the render process), we'll use a different mojo URL (e.g. mojo:cdm) and host it in the utility process separately. BUG=522298, 403462 Committed: https://crrev.com/3f59257a99c050fa63a00efd44f8a5169afd949d Cr-Commit-Position: refs/heads/master@{#399929}

Patch Set 1 #

Patch Set 2 : more fixes #

Patch Set 3 : media: Run mojo media application in GPU process on desktop by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M media/media_options.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/service_factory_impl.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
xhwang
sandersd: This should unblock you from experimenting and even enabling mojo video decoder on desktop. ...
4 years, 6 months ago (2016-06-14 22:23:24 UTC) #2
sandersd (OOO until July 31)
lgtm % 'igpu' in description.
4 years, 6 months ago (2016-06-14 23:02:39 UTC) #3
xhwang
FYI, I am fixing an issue where "mojo_media_client_" isn't declared when ENABLE_MOJO_VIDEO_DECODER is true. It ...
4 years, 6 months ago (2016-06-14 23:37:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067073002/40001
4 years, 6 months ago (2016-06-15 04:54:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/87823)
4 years, 6 months ago (2016-06-15 05:52:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067073002/40001
4 years, 6 months ago (2016-06-15 16:23:04 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-15 16:53:48 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 16:53:58 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:56:03 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3f59257a99c050fa63a00efd44f8a5169afd949d
Cr-Commit-Position: refs/heads/master@{#399929}

Powered by Google App Engine
This is Rietveld 408576698