chrome/browser/extensions/extension_tab_util.cc - Issue 2067033002: Discarded property on chrome.tabs.Tab and chrome.tabs.query()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 2067033002: Discarded property on chrome.tabs.Tab and chrome.tabs.query() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/tabs/tabs_api.cc ('K') | « chrome/browser/extensions/api/tabs/tabs_api_unittest.cc ('k') | chrome/common/extensions/api/tabs.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tab_util.cc

diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc

index f7ca730849d62952f1d3d0b5a88dac1b4de9ca89..0280d06cbec4423e2979ce99a2068306509b0dc8 100644

--- a/chrome/browser/extensions/extension_tab_util.cc

+++ b/chrome/browser/extensions/extension_tab_util.cc

@@ -10,12 +10,14 @@

#include "base/strings/string_number_conversions.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

+#include "chrome/browser/browser_process.h"

#include "chrome/browser/extensions/api/tabs/tabs_constants.h"

#include "chrome/browser/extensions/chrome_extension_function.h"

#include "chrome/browser/extensions/chrome_extension_function_details.h"

#include "chrome/browser/extensions/tab_helper.h"

#include "chrome/browser/extensions/window_controller.h"

#include "chrome/browser/extensions/window_controller_list.h"

+#include "chrome/browser/memory/tab_manager.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/sessions/session_tab_helper.h"

#include "chrome/browser/ui/browser.h"

@@ -387,6 +389,10 @@ std::unique_ptr<api::tabs::Tab> ExtensionTabUtil::CreateTabObject(

tab_object->highlighted = tab_strip && tab_strip->IsTabSelected(tab_index);

tab_object->pinned = tab_strip && tab_strip->IsTabPinned(tab_index);

tab_object->audible.reset(new bool(contents->WasRecentlyAudible()));

+ memory::TabManager* tab_manager = g_browser_process->GetTabManager();

Devlin 2016/07/11 20:25:04 it might be worth adding simple test for this (eve

Anderson Silva 2016/07/11 21:25:55 Done.

+ tab_object->discarded = tab_manager && tab_manager->IsTabDiscarded(contents);

tab_object->muted_info = CreateMutedInfo(contents);

tab_object->incognito = contents->GetBrowserContext()->IsOffTheRecord();

tab_object->width.reset(