Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 2067033002: Discarded property on chrome.tabs.Tab and chrome.tabs.query() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added lambda expression to simplify test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/tabs/tabs_api.h" 5 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <algorithm> 8 #include <algorithm>
9 #include <limits> 9 #include <limits>
10 #include <memory> 10 #include <memory>
11 #include <utility> 11 #include <utility>
12 #include <vector> 12 #include <vector>
13 13
14 #include "base/bind.h" 14 #include "base/bind.h"
15 #include "base/command_line.h" 15 #include "base/command_line.h"
16 #include "base/location.h" 16 #include "base/location.h"
17 #include "base/logging.h" 17 #include "base/logging.h"
18 #include "base/memory/ptr_util.h" 18 #include "base/memory/ptr_util.h"
19 #include "base/memory/ref_counted_memory.h" 19 #include "base/memory/ref_counted_memory.h"
20 #include "base/single_thread_task_runner.h" 20 #include "base/single_thread_task_runner.h"
21 #include "base/stl_util.h" 21 #include "base/stl_util.h"
22 #include "base/strings/pattern.h" 22 #include "base/strings/pattern.h"
23 #include "base/strings/string16.h" 23 #include "base/strings/string16.h"
24 #include "base/strings/string_number_conversions.h" 24 #include "base/strings/string_number_conversions.h"
25 #include "base/strings/string_util.h" 25 #include "base/strings/string_util.h"
26 #include "base/strings/stringprintf.h" 26 #include "base/strings/stringprintf.h"
27 #include "base/strings/utf_string_conversions.h" 27 #include "base/strings/utf_string_conversions.h"
28 #include "base/threading/thread_task_runner_handle.h" 28 #include "base/threading/thread_task_runner_handle.h"
29 #include "chrome/browser/browser_process.h"
29 #include "chrome/browser/chrome_notification_types.h" 30 #include "chrome/browser/chrome_notification_types.h"
30 #include "chrome/browser/extensions/api/tabs/tabs_constants.h" 31 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
31 #include "chrome/browser/extensions/api/tabs/windows_util.h" 32 #include "chrome/browser/extensions/api/tabs/windows_util.h"
32 #include "chrome/browser/extensions/extension_service.h" 33 #include "chrome/browser/extensions/extension_service.h"
33 #include "chrome/browser/extensions/extension_tab_util.h" 34 #include "chrome/browser/extensions/extension_tab_util.h"
34 #include "chrome/browser/extensions/tab_helper.h" 35 #include "chrome/browser/extensions/tab_helper.h"
35 #include "chrome/browser/extensions/window_controller.h" 36 #include "chrome/browser/extensions/window_controller.h"
36 #include "chrome/browser/extensions/window_controller_list.h" 37 #include "chrome/browser/extensions/window_controller_list.h"
38 #include "chrome/browser/memory/tab_manager.h"
37 #include "chrome/browser/prefs/incognito_mode_prefs.h" 39 #include "chrome/browser/prefs/incognito_mode_prefs.h"
38 #include "chrome/browser/profiles/profile.h" 40 #include "chrome/browser/profiles/profile.h"
39 #include "chrome/browser/sessions/session_tab_helper.h" 41 #include "chrome/browser/sessions/session_tab_helper.h"
40 #include "chrome/browser/translate/chrome_translate_client.h" 42 #include "chrome/browser/translate/chrome_translate_client.h"
41 #include "chrome/browser/ui/apps/chrome_app_delegate.h" 43 #include "chrome/browser/ui/apps/chrome_app_delegate.h"
42 #include "chrome/browser/ui/browser.h" 44 #include "chrome/browser/ui/browser.h"
43 #include "chrome/browser/ui/browser_commands.h" 45 #include "chrome/browser/ui/browser_commands.h"
44 #include "chrome/browser/ui/browser_finder.h" 46 #include "chrome/browser/ui/browser_finder.h"
45 #include "chrome/browser/ui/browser_list.h" 47 #include "chrome/browser/ui/browser_list.h"
46 #include "chrome/browser/ui/browser_navigator.h" 48 #include "chrome/browser/ui/browser_navigator.h"
(...skipping 912 matching lines...) Expand 10 before | Expand all | Expand 10 after
959 961
960 if (!window_type.empty() && 962 if (!window_type.empty() &&
961 window_type != 963 window_type !=
962 browser->extension_window_controller()->GetWindowTypeText()) { 964 browser->extension_window_controller()->GetWindowTypeText()) {
963 continue; 965 continue;
964 } 966 }
965 967
966 TabStripModel* tab_strip = browser->tab_strip_model(); 968 TabStripModel* tab_strip = browser->tab_strip_model();
967 for (int i = 0; i < tab_strip->count(); ++i) { 969 for (int i = 0; i < tab_strip->count(); ++i) {
968 WebContents* web_contents = tab_strip->GetWebContentsAt(i); 970 WebContents* web_contents = tab_strip->GetWebContentsAt(i);
971 memory::TabManager* tab_manager = g_browser_process->GetTabManager();
969 972
970 if (index > -1 && i != index) 973 if (index > -1 && i != index)
971 continue; 974 continue;
972 975
973 if (!MatchesBool(params->query_info.highlighted.get(), 976 if (!MatchesBool(params->query_info.highlighted.get(),
974 tab_strip->IsTabSelected(i))) { 977 tab_strip->IsTabSelected(i))) {
975 continue; 978 continue;
976 } 979 }
977 980
978 if (!MatchesBool(params->query_info.active.get(), 981 if (!MatchesBool(params->query_info.active.get(),
979 i == tab_strip->active_index())) { 982 i == tab_strip->active_index())) {
980 continue; 983 continue;
981 } 984 }
982 985
983 if (!MatchesBool(params->query_info.pinned.get(), 986 if (!MatchesBool(params->query_info.pinned.get(),
984 tab_strip->IsTabPinned(i))) { 987 tab_strip->IsTabPinned(i))) {
985 continue; 988 continue;
986 } 989 }
987 990
988 if (!MatchesBool(params->query_info.audible.get(), 991 if (!MatchesBool(params->query_info.audible.get(),
989 web_contents->WasRecentlyAudible())) { 992 web_contents->WasRecentlyAudible())) {
990 continue; 993 continue;
991 } 994 }
992 995
996 // If tab_manager isn't present, then no tabs are discarded.
997 bool discarded = tab_manager && tab_manager->IsTabDiscarded(web_contents);
998 if (!MatchesBool(params->query_info.discarded.get(), discarded))
999 continue;
1000
993 if (!MatchesBool(params->query_info.muted.get(), 1001 if (!MatchesBool(params->query_info.muted.get(),
994 web_contents->IsAudioMuted())) { 1002 web_contents->IsAudioMuted())) {
995 continue; 1003 continue;
996 } 1004 }
997 1005
998 if (!title.empty() || !url_patterns.is_empty()) { 1006 if (!title.empty() || !url_patterns.is_empty()) {
999 // "title" and "url" properties are considered privileged data and can 1007 // "title" and "url" properties are considered privileged data and can
1000 // only be checked if the extension has the "tabs" permission or it has 1008 // only be checked if the extension has the "tabs" permission or it has
1001 // access to the WebContents's origin. Otherwise, this tab is considered 1009 // access to the WebContents's origin. Otherwise, this tab is considered
1002 // not matched. 1010 // not matched.
(...skipping 1151 matching lines...) Expand 10 before | Expand all | Expand 10 after
2154 ZoomModeToZoomSettings(zoom_mode, &zoom_settings); 2162 ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
2155 zoom_settings.default_zoom_factor.reset(new double( 2163 zoom_settings.default_zoom_factor.reset(new double(
2156 content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel()))); 2164 content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel())));
2157 2165
2158 results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings); 2166 results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
2159 SendResponse(true); 2167 SendResponse(true);
2160 return true; 2168 return true;
2161 } 2169 }
2162 2170
2163 } // namespace extensions 2171 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698