Discarded property on chrome.tabs.Tab and chrome.tabs.query()

chrome/browser/extensions/extension_tab_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tab_util.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
 #include "chrome/browser/extensions/chrome_extension_function_details.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/extensions/window_controller_list.h"
+#include "chrome/browser/memory/tab_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_navigator_params.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ skipping 352 matching lines @@
   std::unique_ptr<api::tabs::Tab> tab_object(new api::tabs::Tab);
   tab_object->id.reset(new int(GetTabIdForExtensions(contents)));
   tab_object->index = tab_index;
   tab_object->window_id = GetWindowIdOfTab(contents);
   tab_object->status.reset(new std::string(GetTabStatusText(is_loading)));
   tab_object->active = tab_strip && tab_index == tab_strip->active_index();
   tab_object->selected = tab_strip && tab_index == tab_strip->active_index();
   tab_object->highlighted = tab_strip && tab_strip->IsTabSelected(tab_index);
   tab_object->pinned = tab_strip && tab_strip->IsTabPinned(tab_index);
   tab_object->audible.reset(new bool(contents->WasRecentlyAudible()));
+
+  memory::TabManager* tab_manager =
+      g_browser_process ? g_browser_process->GetTabManager() : nullptr;

[chrisha, 2016/06/15 15:56:12]

Can g_browser_process every not exist in this context? ie: it's likely safe to
simply:

DCHECK(g_browser_process);
memory::TabManager* tab_manager = g_browser_process->GetTabManager();

[Georges Khalil, 2016/06/15 17:25:42]

Looking at similar code, we can even forgo the DCHECK here and just assume the
pointer valid.

[Anderson Silva, 2016/06/16 14:04:51]

Acknowledged.

+  tab_object->discarded = tab_manager && tab_manager->IsTabDiscarded(contents);
+
   tab_object->muted_info = CreateMutedInfo(contents);
   tab_object->incognito = contents->GetBrowserContext()->IsOffTheRecord();
   tab_object->width.reset(
       new int(contents->GetContainerBounds().size().width()));
   tab_object->height.reset(
       new int(contents->GetContainerBounds().size().height()));
 
   tab_object->url.reset(new std::string(contents->GetURL().spec()));
   tab_object->title.reset(
       new std::string(base::UTF16ToUTF8(contents->GetTitle())));
@@ skipping 263 matching lines @@
   chrome::ShowSingletonTabOverwritingNTP(browser, params);
   return true;
 }
 
 // static
 bool ExtensionTabUtil::BrowserSupportsTabs(Browser* browser) {
   return browser && browser->tab_strip_model() && !browser->is_devtools();
 }
 
 }  // namespace extensions