Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2067023002: Enable viewer in non-Vulkan builds (Closed)

Created:
4 years, 6 months ago by jvanverth1
Modified:
4 years, 6 months ago
Reviewers:
egdaniel, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleaned up for Unix and Android #

Patch Set 3 : Only include XCB if using Vulkan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M gyp/most.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M gyp/viewer.gyp View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M tools/viewer/Viewer.cpp View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/Window.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/Window.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/android/Window_android.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download
M tools/viewer/sk_app/unix/GLWindowContext_unix.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/viewer/sk_app/unix/Window_unix.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M tools/viewer/sk_app/win/Window_win.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
jvanverth1
This is partially a set-up for Mac and iOS builds, but it's also useful for ...
4 years, 6 months ago (2016-06-15 18:05:47 UTC) #3
djsollen
lgtm
4 years, 6 months ago (2016-06-15 18:33:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067023002/20001
4 years, 6 months ago (2016-06-15 19:49:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/746b792a9aad1230ab69158a51c49b2e5437d95b
4 years, 6 months ago (2016-06-15 20:44:19 UTC) #8
egdaniel
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2072563002/ by egdaniel@google.com. ...
4 years, 6 months ago (2016-06-15 21:23:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067023002/40001
4 years, 6 months ago (2016-06-17 16:13:51 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 16:29:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/063ece71848fadc963cbac5c978cd48262138131

Powered by Google App Engine
This is Rietveld 408576698