Suppress leveldb recursion warning on official builds

Suppress leveldb recursion warning on official builds

VS 2015 issues this warning on official builds of some targets:

warning C4717: 'leveldb::InternalFilterPolicy::CreateFilter': recursive on all control paths

However this not actually a problem. Suppressing the warning allows all
targets to build in official gn builds.

The problem was solved on gyp builds by disabling WarnAsError on
official builds. This fix seems cleaner.

BUG=620018
Committed: https://crrev.com/d3a998e1c84c2162c79852454ab8944177fccaa7
Cr-Commit-Position: refs/heads/master@{#399992}

[brucedawson, 2016-06-14 21:04:08]

brucedawson@chromium.org changed reviewers:
+ michaeln@chromium.org

[brucedawson, 2016-06-14 21:04:09]

PTAL. Details in the description and bug.

[michaeln, 2016-06-14 22:23:42]

lgtm (and cmumford too)

[brucedawson, 2016-06-14 23:18:57]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-06-14 23:19:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067003002/1

[commit-bot: I haz the power, 2016-06-14 23:42:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 23:42:36]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[brucedawson, 2016-06-15 19:41:48]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-06-15 19:42:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067003002/1

[commit-bot: I haz the power, 2016-06-15 19:46:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-15 19:46:22]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-15 19:47:40]

Description was changed from

==========
Suppress leveldb recursion warning on official builds

VS 2015 issues this warning on official builds of some targets:

warning C4717: 'leveldb::InternalFilterPolicy::CreateFilter': recursive on all
control paths

However this not actually a problem. Suppressing the warning allows all
targets to build in official gn builds.

The problem was solved on gyp builds by disabling WarnAsError on
official builds. This fix seems cleaner.

BUG=620018
==========

to

==========
Suppress leveldb recursion warning on official builds

VS 2015 issues this warning on official builds of some targets:

warning C4717: 'leveldb::InternalFilterPolicy::CreateFilter': recursive on all
control paths

However this not actually a problem. Suppressing the warning allows all
targets to build in official gn builds.

The problem was solved on gyp builds by disabling WarnAsError on
official builds. This fix seems cleaner.

BUG=620018

Committed: https://crrev.com/d3a998e1c84c2162c79852454ab8944177fccaa7
Cr-Commit-Position: refs/heads/master@{#399992}
==========

[commit-bot: I haz the power, 2016-06-15 19:47:41]

Patchset 1 (id:??) landed as
https://crrev.com/d3a998e1c84c2162c79852454ab8944177fccaa7
Cr-Commit-Position: refs/heads/master@{#399992}