Source/core/page/EventHandler.cpp - Issue 20670002: REGRESSION: Click on focused link should not remove focus on it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 20670002: REGRESSION: Click on focused link should not remove focus on it. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: typo Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 2e738efec24fa8c56fee19b372ea843f9034eea5..5e64e1c413a8a99e287bf774462bfccbbd76b242 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -2034,7 +2034,7 @@ bool EventHandler::dispatchMouseEvent(const AtomicString& eventType, Node* targe

// Walk up the DOM tree to search for a node to focus.

while (node) {

- if (node->isMouseFocusable()) {

+ if (node->isFocusable()) {

// To fix <rdar://problem/4895428> Can't drag selected ToDo, we don't focus a

// node on mouse down if it's selected and inside a focused node. It will be

// focused if the user does a mouseup over it, however, because the mouseup