Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 2066993006: Reland of Pin dEQP DEPS to ANGLE's DEPS.chromium. (Closed)

Created:
4 years, 6 months ago by Jamie Madill
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Pin dEQP DEPS to ANGLE's DEPS.chromium. (patchset #1 id:1 of https://codereview.chromium.org/1966243002/ ) Reason for revert: buildspec creation should be now fixed. Original issue's description: > Revert of Pin dEQP DEPS to ANGLE's DEPS.chromium. (patchset #1 id:1 of https://codereview.chromium.org/1966743002/ ) > > Reason for revert: > Using "recursedeps" broke buildspec creation. > > Original issue's description: > > Pin dEQP DEPS to ANGLE's DEPS.chromium. > > > > This file will manage which dEQP revision Chrome checks out. This > > allows ANGLE to roll dEQP in the same CL as it updates the build > > files, which makes testing on the bots possible. > > > > BUG=605987 > > R=iannucci@chromium.org > > > > Committed: https://crrev.com/bf887ad07e2d7fb199832c52c87cc1647c826806 > > Cr-Commit-Position: refs/heads/master@{#392697} > > TBR=iannucci@chromium.org,dpranke@chromium.org,agable@chromium.org,jmadill@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=605987 > > Committed: https://crrev.com/b627a76883d422736db77ef71fafe26d7f3b3812 > Cr-Commit-Position: refs/heads/master@{#392930} TBR=iannucci@chromium.org,dpranke@chromium.org,agable@chromium.org,mmoss@chromium.org,mmoss@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605987 Committed: https://crrev.com/d2dfc8fbfccf3228b6c8ed8c1ccf071559f5523e Cr-Commit-Position: refs/heads/master@{#400169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M DEPS View 4 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie Madill
Created Reland of Pin dEQP DEPS to ANGLE's DEPS.chromium.
4 years, 6 months ago (2016-06-16 14:39:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066993006/1
4 years, 6 months ago (2016-06-16 14:39:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 16:25:28 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d2dfc8fbfccf3228b6c8ed8c1ccf071559f5523e Cr-Commit-Position: refs/heads/master@{#400169}
4 years, 6 months ago (2016-06-16 16:26:44 UTC) #6
Dirk Pranke
4 years, 6 months ago (2016-06-16 17:50:46 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698