Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2066983004: Work around iossim compile issues on latest Xcode beta. (Closed)

Created:
4 years, 6 months ago by justincohen
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around iossim compile issues on latest Xcode beta. iossim is broken with the latest Xcode beta. At least allow it to compile for now while we look for a solution. BUG=619813, 619982 Committed: https://crrev.com/3c81dff80fe630802d17adc43a73ebf77e43018b Cr-Commit-Position: refs/heads/master@{#400177}

Patch Set 1 #

Patch Set 2 : Fix grammar #

Total comments: 4

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M testing/iossim/iossim.mm View 1 2 3 chunks +27 lines, -0 lines 0 comments Download
M third_party/class-dump/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/class-dump/class-dump.gyp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
justincohen
ptal
4 years, 6 months ago (2016-06-15 20:22:04 UTC) #2
rohitrao (ping after 24h)
Why was libcrypto in here in the first place, if it wasn't really needed? How ...
4 years, 6 months ago (2016-06-15 20:26:55 UTC) #3
justincohen
It's hard to tell, since we used to pull from an internal class-dump.git repo that ...
4 years, 6 months ago (2016-06-15 20:33:12 UTC) #4
justincohen
nygard@'s project at https://github.com/nygard/class-dump does include -lcrypto, but it doesn't appear to need it. That ...
4 years, 6 months ago (2016-06-15 20:34:58 UTC) #5
rohitrao (ping after 24h)
Do you intend to land this iossim workaround, or should we wait for the better ...
4 years, 6 months ago (2016-06-16 14:50:17 UTC) #6
justincohen
ptal https://codereview.chromium.org/2066983004/diff/20001/testing/iossim/iossim.mm File testing/iossim/iossim.mm (right): https://codereview.chromium.org/2066983004/diff/20001/testing/iossim/iossim.mm#newcode27 testing/iossim/iossim.mm:27: #if defined(__MAC_10_12) && __MAC_OS_X_VERSION_MAX_ALLOWED >= __MAC_10_12 On 2016/06/16 ...
4 years, 6 months ago (2016-06-16 15:07:07 UTC) #7
rohitrao (ping after 24h)
lgtm
4 years, 6 months ago (2016-06-16 15:07:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066983004/40001
4 years, 6 months ago (2016-06-16 15:08:23 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-16 16:55:56 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 16:55:59 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 16:57:40 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3c81dff80fe630802d17adc43a73ebf77e43018b
Cr-Commit-Position: refs/heads/master@{#400177}

Powered by Google App Engine
This is Rietveld 408576698