Work around iossim compile issues on latest Xcode beta.

Work around iossim compile issues on latest Xcode beta.

iossim is broken with the latest Xcode beta.  At least allow it to compile for
now while we look for a solution.

BUG=619813, 619982
Committed: https://crrev.com/3c81dff80fe630802d17adc43a73ebf77e43018b
Cr-Commit-Position: refs/heads/master@{#400177}

[justincohen, 2016-06-15 20:22:03]

justincohen@chromium.org changed reviewers:
+ rohitrao@chromium.org

[justincohen, 2016-06-15 20:22:04]

ptal

[rohitrao (ping after 24h), 2016-06-15 20:26:55]

Why was libcrypto in here in the first place, if it wasn't really needed?  How
long ago was that added?

[justincohen, 2016-06-15 20:33:12]

It's hard to tell, since we used to pull from an internal class-dump.git repo
that is no longer in use.  It's been there as far back as I can go.

[justincohen, 2016-06-15 20:34:58]

nygard@'s project at https://github.com/nygard/class-dump does include -lcrypto,
but it doesn't appear to need it.  That project also fails on Xcode 8.

[rohitrao (ping after 24h), 2016-06-16 14:50:17]

Do you intend to land this iossim workaround, or should we wait for the better
solution?

https://codereview.chromium.org/2066983004/diff/20001/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://codereview.chromium.org/2066983004/diff/20001/testing/iossim/iossim.m...
testing/iossim/iossim.mm:27: #if defined(__MAC_10_12) &&
__MAC_OS_X_VERSION_MAX_ALLOWED >= __MAC_10_12
I would split this block into two, putting one at old line 34, just before
#import "CoreSimulator.h", and the other at old line 59, just before #import
"DVTiPhoneSimulatorRemoteClient.h".

https://codereview.chromium.org/2066983004/diff/20001/testing/iossim/iossim.m...
testing/iossim/iossim.mm:28: @class NSPasteboardItem;
You should at least be able to get NSPasteboardItem with:
#import <AppKit/AppKit.h>

[justincohen, 2016-06-16 15:07:07]

ptal

https://codereview.chromium.org/2066983004/diff/20001/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://codereview.chromium.org/2066983004/diff/20001/testing/iossim/iossim.m...
testing/iossim/iossim.mm:27: #if defined(__MAC_10_12) &&
__MAC_OS_X_VERSION_MAX_ALLOWED >= __MAC_10_12
On 2016/06/16 14:50:17, rohitrao wrote:
> I would split this block into two, putting one at old line 34, just before
> #import "CoreSimulator.h", and the other at old line 59, just before #import
> "DVTiPhoneSimulatorRemoteClient.h".

Done.

https://codereview.chromium.org/2066983004/diff/20001/testing/iossim/iossim.m...
testing/iossim/iossim.mm:28: @class NSPasteboardItem;
On 2016/06/16 14:50:17, rohitrao wrote:
> You should at least be able to get NSPasteboardItem with:
> #import <AppKit/AppKit.h>

Done.

[rohitrao (ping after 24h), 2016-06-16 15:07:46]

lgtm

[justincohen, 2016-06-16 15:07:56]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-06-16 15:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066983004/40001

[commit-bot: I haz the power, 2016-06-16 16:55:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-16 16:55:59]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 16:57:39]

Description was changed from

==========
Work around iossim compile issues on latest Xcode beta.

iossim is broken with the latest Xcode beta.  At least allow it to compile for
now while we look for a solution.

BUG=619813, 619982
==========

to

==========
Work around iossim compile issues on latest Xcode beta.

iossim is broken with the latest Xcode beta.  At least allow it to compile for
now while we look for a solution.

BUG=619813, 619982

Committed: https://crrev.com/3c81dff80fe630802d17adc43a73ebf77e43018b
Cr-Commit-Position: refs/heads/master@{#400177}
==========

[commit-bot: I haz the power, 2016-06-16 16:57:40]

Patchset 3 (id:??) landed as
https://crrev.com/3c81dff80fe630802d17adc43a73ebf77e43018b
Cr-Commit-Position: refs/heads/master@{#400177}