android_full_debug x86 fix - use +rm for width count

android_full_debug x86 fix - use +rm for width count

Work around for android full debug build runnign out of registers.
5 functions were running out of registers causing the compiler error
error: 'asm' operand has impossible constraints
These functions mostly have 4 pointers, a counter (width) and a tempory
eax register.  With fpic and debug using stackframes, 2 registers are
unavailable.  So a total of 8 registers are used.
Although fpic and stack frame dont apply to assembly, the compiler
reserves 2 registers.  The optimized version builds, so its likely
freeing up the registers once it knows they are not used.
These functions used to build, so compile options and/or compiler may
have updated.. likely fpic was turned on.
An attribute can be done to disable each, and will avoid using the
2 GPR registers, but they are still reserved and unavailable in debug
builds on current compilers (gcc 4.9 and clang 3.8).

R=dhrosa@google.com
BUG=libyuv:602
Committed: https://chromium.googlesource.com/libyuv/libyuv/+/fd3e676e91b30439dd8515fc760093f90d856bb7

[Diony Rosa, 2016-06-14 18:18:13]

https://codereview.chromium.org/2066933002/diff/1/README.chromium
File README.chromium (right):

https://codereview.chromium.org/2066933002/diff/1/README.chromium#newcode3
README.chromium:3: Version: 1598
Why did the version number jump by 2?

[fbarchard1, 2016-06-14 19:05:19]

On 2016/06/14 18:18:13, Diony Rosa wrote:
> https://codereview.chromium.org/2066933002/diff/1/README.chromium
> File README.chromium (right):
> 
> https://codereview.chromium.org/2066933002/diff/1/README.chromium#newcode3
> README.chromium:3: Version: 1598
> Why did the version number jump by 2?

8 is good luck
oops.  fixed version

[Diony Rosa, 2016-06-14 20:14:28]

lgtm

[fbarchard1, 2016-06-14 22:25:31]

Description was changed from

==========
android_full_debug x86 fix - use +rm for width count

Work around for android full debug build runnign out of registers.
5 functions were running out of registers causing the compiler error
error: 'asm' operand has impossible constraints
These functions mostly have 4 pointers, a counter (width) and a tempory
eax register.  With fpic and debug using stackframes, 2 registers are
unavailable.  So a total of 8 registers are used.
Although fpic and stack frame dont apply to assembly, the compiler
reserves 2 registers.  The optimized version builds, so its likely
freeing up the registers once it knows they are not used.
These functions used to build, so compile options and/or compiler may
have updated.. likely fpic was turned on.
An attribute can be done to disable each, and will avoid using the
2 GPR registers, but they are still reserved and unavailable in debug
builds on current compilers (gcc 4.9 and clang 3.8).

R=dhrosa@google.com
BUG=libyuv:602
==========

to

==========
android_full_debug x86 fix - use +rm for width count

Work around for android full debug build runnign out of registers.
5 functions were running out of registers causing the compiler error
error: 'asm' operand has impossible constraints
These functions mostly have 4 pointers, a counter (width) and a tempory
eax register.  With fpic and debug using stackframes, 2 registers are
unavailable.  So a total of 8 registers are used.
Although fpic and stack frame dont apply to assembly, the compiler
reserves 2 registers.  The optimized version builds, so its likely
freeing up the registers once it knows they are not used.
These functions used to build, so compile options and/or compiler may
have updated.. likely fpic was turned on.
An attribute can be done to disable each, and will avoid using the
2 GPR registers, but they are still reserved and unavailable in debug
builds on current compilers (gcc 4.9 and clang 3.8).

R=dhrosa@google.com
BUG=libyuv:602

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/fd3e676e91b30439dd8515fc760...
==========

[fbarchard1, 2016-06-14 22:25:32]

Committed patchset #2 (id:20001) manually as
fd3e676e91b30439dd8515fc760093f90d856bb7 (presubmit successful).