Update media browser tests to observe plugin crashes!

Update media browser tests to observe plugin crashes while running tests.

With this CL, by defualt, when a plugin crashes it logs the crash, fails the test and updates TitleWatcher to 'PLUGIN_CRASHED'.

BUG=351860
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258705

[shadi1, 2014-03-20 21:07:08]

PTAL

This CL makes media browser tests observe web contents and fail tests when a
plugin crashes.

[ddorwin, 2014-03-21 17:06:29]

It looks like the description is missing some words.

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/encrypt...
File chrome/browser/media/encrypted_media_browsertest.cc (right):

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/encrypt...
chrome/browser/media/encrypted_media_browsertest.cc:634:
IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, CDMExpectedCrash) {
This is really testing the test framework, right? Maybe we should mention that.

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/media_b...
File chrome/browser/media/media_browsertest.cc (right):

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/media_b...
chrome/browser/media/media_browsertest.cc:89: EXPECT_TRUE(ignore_plugin_crash_)
<< "Failing test due to plugin crash.";
You don't actually expect ignore_plugin_crash_ to be true. That would be
misleading for someone to see.

I think you want ADD_FAILURE() << ...

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/media_b...
File chrome/browser/media/media_browsertest.h (right):

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/media_b...
chrome/browser/media/media_browsertest.h:56: void IgnorePluginCrash(bool
ignore);
nit: This should probably either not take a bool or begin with "Set". Also, this
could be a setter: set_ignore_plugin_crash(bool).

[shadi1, 2014-03-21 18:43:53]

PTAL

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/encrypt...
File chrome/browser/media/encrypted_media_browsertest.cc (right):

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/encrypt...
chrome/browser/media/encrypted_media_browsertest.cc:634:
IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, CDMExpectedCrash) {
On 2014/03/21 17:06:29, ddorwin wrote:
> This is really testing the test framework, right? Maybe we should mention
that.

Done.

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/media_b...
File chrome/browser/media/media_browsertest.cc (right):

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/media_b...
chrome/browser/media/media_browsertest.cc:89: EXPECT_TRUE(ignore_plugin_crash_)
<< "Failing test due to plugin crash.";
On 2014/03/21 17:06:29, ddorwin wrote:
> You don't actually expect ignore_plugin_crash_ to be true. That would be
> misleading for someone to see.
> 
> I think you want ADD_FAILURE() << ...

Done.

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/media_b...
File chrome/browser/media/media_browsertest.h (right):

https://codereview.chromium.org/206693004/diff/1/chrome/browser/media/media_b...
chrome/browser/media/media_browsertest.h:56: void IgnorePluginCrash(bool
ignore);
On 2014/03/21 17:06:29, ddorwin wrote:
> nit: This should probably either not take a bool or begin with "Set". Also,
this
> could be a setter: set_ignore_plugin_crash(bool).
I think not having it take a bool seems good (until we have a case that needs to
switch between ignore and not ignore in the same test).

[ddorwin, 2014-03-21 18:46:26]

lgtm. Thanks.

[shadi1, 2014-03-21 18:50:42]

The CQ bit was checked by shadi@google.com

[commit-bot: I haz the power, 2014-03-21 18:51:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/206693004/20001

[commit-bot: I haz the power, 2014-03-21 22:50:34]

Change committed as 258705