Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2066843002: printing::Image: remove unused constructor (Closed)

Created:
4 years, 6 months ago by hal.canary
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

printing::Image: remove unused constructor BUG= Committed: https://crrev.com/de0b6c94961b7234c1c2da0f0c7fa09ff2672bfa Cr-Commit-Position: refs/heads/master@{#399738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M printing/image.h View 2 chunks +0 lines, -7 lines 0 comments Download
M printing/image.cc View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066843002/1
4 years, 6 months ago (2016-06-14 15:54:10 UTC) #2
hal.canary
PTAL This is a smaller change that removes one use of PdfMetafileSkia::InitFromData.
4 years, 6 months ago (2016-06-14 16:29:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 16:43:22 UTC) #6
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-14 17:40:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066843002/1
4 years, 6 months ago (2016-06-14 17:40:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 17:46:31 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 17:47:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de0b6c94961b7234c1c2da0f0c7fa09ff2672bfa
Cr-Commit-Position: refs/heads/master@{#399738}

Powered by Google App Engine
This is Rietveld 408576698