A remotable font management interface and DirectWrite implementation.

A remotable font management interface and DirectWrite implementation.

The introduced SkRemotableFontMgr is a font management interface designed for simple and fast proxy support. SkFontMgr_Indirect bridges a SkRemotableFontMgr and a local SkFontMgr to present a SkFontMgr interface.

This change is to be followed by https://codereview.chromium.org/132113015/ and  https://codereview.chromium.org/206693003 .

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13897

[reed1, 2014-03-21 19:56:53]

Lets try to offer even more opaque helpers so that chrome sees even less
exposure to our headers/impl-decisions.

e.g. SkFontMgr* SkCreateRemotableDirectWrite(chrome_remoter_subclass)

lgtm

https://codereview.chromium.org/206683002/diff/20001/include/ports/SkFontMgr.h
File include/ports/SkFontMgr.h (right):

https://codereview.chromium.org/206683002/diff/20001/include/ports/SkFontMgr....
include/ports/SkFontMgr.h:74: const char bpc47[], uint32_t character) const;
nit: SkUnichar

https://codereview.chromium.org/206683002/diff/20001/include/ports/SkFontMgr_...
File include/ports/SkFontMgr_indirect.h (right):

https://codereview.chromium.org/206683002/diff/20001/include/ports/SkFontMgr_...
include/ports/SkFontMgr_indirect.h:26: SkFontMgr_Indirect(SkFontMgr* impl,
SkRemotableFontMgr* proxy)
// Document that all we really want is createFromStream -- which we hope to
separate out later

[bungeman-skia, 2014-03-21 22:36:11]

Added SkFontMgr_New_DirectWriteRenderer. This allows us to hide
SkFontMgr_Indirect and its constructor from Chromium.

https://codereview.chromium.org/206683002/diff/20001/include/ports/SkFontMgr.h
File include/ports/SkFontMgr.h (right):

https://codereview.chromium.org/206683002/diff/20001/include/ports/SkFontMgr....
include/ports/SkFontMgr.h:74: const char bpc47[], uint32_t character) const;
On 2014/03/21 19:56:53, reed1 wrote:
> nit: SkUnichar

I know it shouldn't really matter, but every other interface uses unsigned for
codepoints (SkUnichar is int32_t). DirectWrite uses UINT32, CoreText seems stuck
on UTF-16 for everything, FontConfig uses FcChar32 which is, somewhat
frighteningly, just 'unsigned int'. I suppose we could change it.

https://codereview.chromium.org/206683002/diff/20001/include/ports/SkFontMgr_...
File include/ports/SkFontMgr_indirect.h (right):

https://codereview.chromium.org/206683002/diff/20001/include/ports/SkFontMgr_...
include/ports/SkFontMgr_indirect.h:26: SkFontMgr_Indirect(SkFontMgr* impl,
SkRemotableFontMgr* proxy)
On 2014/03/21 19:56:53, reed1 wrote:
> // Document that all we really want is createFromStream -- which we hope to
> separate out later

Done.

[bungeman-chromium, 2014-03-21 22:48:38]

Committed patchset #4 manually as r13897 (presubmit successful).

[eae, 2014-03-21 22:49:48]

On 2014/03/21 22:48:38, bungeman2 wrote:
> Committed patchset #4 manually as r13897 (presubmit successful).

Sweet!