Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2066823002: [mb] Set correct default values for sysroot and icu (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mb] Set correct default values for sysroot and icu Port https://codereview.chromium.org/2057053002/ for the v8-side configurations. BUG=chromium:616035 NOTRY=true TBR=vogelheim@chromium.org, jochen@chromium.org Committed: https://crrev.com/f1ac74b2530f837c905dbd7b1924220c6097acae Cr-Commit-Position: refs/heads/master@{#36967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M infra/mb/mb_config.pyl View 3 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR
4 years, 6 months ago (2016-06-14 13:38:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066823002/1
4 years, 6 months ago (2016-06-14 13:38:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 13:40:34 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f1ac74b2530f837c905dbd7b1924220c6097acae Cr-Commit-Position: refs/heads/master@{#36967}
4 years, 6 months ago (2016-06-14 13:42:52 UTC) #9
vogelheim
4 years, 6 months ago (2016-06-14 15:24:47 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698