Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2066793003: Revert "Implement script-side of callback reactions for Custom Elements V1" (Closed)

Created:
4 years, 6 months ago by jbroman
Modified:
4 years, 6 months ago
Reviewers:
haraken, kojii
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Implement script-side of callback reactions for Custom Elements V1" This reverts commit 4f581ae17af347201ede92b01dc47068ee0cf2d5. This commit landed twice, and the second landing caused a function to be defined twice in V8Binding.h. BUG=594918 TBR=kojii@chromium.org NOTRY=true Committed: https://crrev.com/d3b7d5c11891d4de41363cd94b4981bd4a305193 Cr-Commit-Position: refs/heads/master@{#399866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066793003/1
4 years, 6 months ago (2016-06-15 09:02:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 09:05:38 UTC) #3
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 09:05:39 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d3b7d5c11891d4de41363cd94b4981bd4a305193 Cr-Commit-Position: refs/heads/master@{#399866}
4 years, 6 months ago (2016-06-15 09:07:18 UTC) #6
haraken
LGTM
4 years, 6 months ago (2016-06-15 09:09:05 UTC) #7
kojii
4 years, 6 months ago (2016-06-15 09:34:27 UTC) #8
Message was sent while issue was closed.
Thank you for doing this, lgtm too

Powered by Google App Engine
This is Rietveld 408576698