Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2066743004:
[Chromecast] More initialized fields for cast_sys_info_dummy (Closed)
|
Created:
4 years, 6 months ago by yucliu1 Modified:
4 years, 3 months ago CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Chromecast] More initialized fields for cast_sys_info_dummy
Most of the fields in CastSysInfoDummy will have format
dummy.field_name. This will allow run widevine cdm testing code in
desktop build.
BUG=internal b/27699230
TEST=Run widevine testing code
Committed: https://crrev.com/1caf9f859a10429c4db51417c05db90aa5d60a6e
Cr-Commit-Position: refs/heads/master@{#414631}
Patch Set 1 #Patch Set 2 : meaningful names #Messages
Total messages: 14 (5 generated)
Description was changed from ========== [Chromecast] More initialized fields for cast_sys_info_dummy Most of the fields in CastSysInfoDummy will have format dummy.field_name. This will allow run widevine cdm testing code in desktop build. BUG=internal b/27699230 TEST=Run widevine testing code ========== to ========== [Chromecast] More initialized fields for cast_sys_info_dummy Most of the fields in CastSysInfoDummy will have format dummy.field_name. This will allow run widevine cdm testing code in desktop build. BUG=internal b/27699230 TEST=Run widevine testing code ==========
yucliu@chromium.org changed reviewers: + byungchul@chromium.org, derekjchow@chromium.org, halliwell@chromium.org
On 2016/06/14 22:58:02, yucliu1 wrote: Are we going to make license requests against WV's test server from desktop builds? I wonder if we should set these to "real" values, at least slightly more real than dummy.X.
On 2016/06/14 23:44:12, halliwell wrote: > On 2016/06/14 22:58:02, yucliu1 wrote: > > Are we going to make license requests against WV's test server from desktop > builds? I wonder if we should set these to "real" values, at least slightly > more real than dummy.X. Agree. Although we don't have the test now, I believe we should test license request. Let me think more on the details.
On 2016/06/15 00:10:32, yucliu1 wrote: > On 2016/06/14 23:44:12, halliwell wrote: > > On 2016/06/14 22:58:02, yucliu1 wrote: > > > > Are we going to make license requests against WV's test server from desktop > > builds? I wonder if we should set these to "real" values, at least slightly > > more real than dummy.X. > > Agree. Although we don't have the test now, I believe we should test license > request. Let me think more on the details. My understanding is that these fields are somewhat arbitrary, but can be used to analyse data on the licence server. So we could make up some things like "cast_shell" for product name and use the branding string for manufacturer (just examples). Would be nice to populate build # with some kind of useful string. Some of them might be possible to just be empty. Just need to also check that nothing else besides widevine is affected by the values of dummy implementation.
On 2016/06/15 00:14:42, halliwell wrote: > On 2016/06/15 00:10:32, yucliu1 wrote: > > On 2016/06/14 23:44:12, halliwell wrote: > > > On 2016/06/14 22:58:02, yucliu1 wrote: > > > > > > Are we going to make license requests against WV's test server from desktop > > > builds? I wonder if we should set these to "real" values, at least slightly > > > more real than dummy.X. > > > > Agree. Although we don't have the test now, I believe we should test license > > request. Let me think more on the details. > > My understanding is that these fields are somewhat arbitrary, but can be used to > analyse data on the licence server. So we could make up some things like > "cast_shell" for product name and use the branding string for manufacturer (just > examples). Would be nice to populate build # with some kind of useful string. > Some of them might be possible to just be empty. > > Just need to also check that nothing else besides widevine is affected by the > values of dummy implementation. Initialize some fields with more meaning strings.
On 2016/08/26 00:35:57, yucliu1 wrote: > On 2016/06/15 00:14:42, halliwell wrote: > > On 2016/06/15 00:10:32, yucliu1 wrote: > > > On 2016/06/14 23:44:12, halliwell wrote: > > > > On 2016/06/14 22:58:02, yucliu1 wrote: > > > > > > > > Are we going to make license requests against WV's test server from > desktop > > > > builds? I wonder if we should set these to "real" values, at least > slightly > > > > more real than dummy.X. > > > > > > Agree. Although we don't have the test now, I believe we should test license > > > request. Let me think more on the details. > > > > My understanding is that these fields are somewhat arbitrary, but can be used > to > > analyse data on the licence server. So we could make up some things like > > "cast_shell" for product name and use the branding string for manufacturer > (just > > examples). Would be nice to populate build # with some kind of useful string. > > > Some of them might be possible to just be empty. > > > > Just need to also check that nothing else besides widevine is affected by the > > values of dummy implementation. > > Initialize some fields with more meaning strings. lgtm
The CQ bit was checked by yucliu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] More initialized fields for cast_sys_info_dummy Most of the fields in CastSysInfoDummy will have format dummy.field_name. This will allow run widevine cdm testing code in desktop build. BUG=internal b/27699230 TEST=Run widevine testing code ========== to ========== [Chromecast] More initialized fields for cast_sys_info_dummy Most of the fields in CastSysInfoDummy will have format dummy.field_name. This will allow run widevine cdm testing code in desktop build. BUG=internal b/27699230 TEST=Run widevine testing code ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] More initialized fields for cast_sys_info_dummy Most of the fields in CastSysInfoDummy will have format dummy.field_name. This will allow run widevine cdm testing code in desktop build. BUG=internal b/27699230 TEST=Run widevine testing code ========== to ========== [Chromecast] More initialized fields for cast_sys_info_dummy Most of the fields in CastSysInfoDummy will have format dummy.field_name. This will allow run widevine cdm testing code in desktop build. BUG=internal b/27699230 TEST=Run widevine testing code Committed: https://crrev.com/1caf9f859a10429c4db51417c05db90aa5d60a6e Cr-Commit-Position: refs/heads/master@{#414631} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1caf9f859a10429c4db51417c05db90aa5d60a6e Cr-Commit-Position: refs/heads/master@{#414631} |
