Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2066733003: Blacklist untested GPUs for GPU Raster (Closed)

Created:
4 years, 6 months ago by ericrk
Modified:
4 years, 6 months ago
Reviewers:
vmiura, no sievers, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This change blacklists GPU rasterization for all GPUs on MacOS that have not had test coverage. The GPUs which are not blacklisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 7XX GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs ATI: R200 Series GPUs ATI: HD 7XXX series GPUs This gives us roughly 70% GPU Raster enablement on Mac. BUG=614468, 613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/5033c4f6e97a466f03132ed2cbb655a8807e415c Cr-Commit-Position: refs/heads/master@{#401933}

Patch Set 1 : Blacklist GPU raster on Geforce 320M #

Patch Set 2 : Expand to be a whitelist (for M52) #

Patch Set 3 : rebase #

Patch Set 4 : remove extra comma #

Patch Set 5 : remove multi_gpu_category from outer scope #

Patch Set 6 : remove all multi_gpu_categories #

Patch Set 7 : Move to blacklist #

Patch Set 8 : Remove recently tested GPUs from blacklist #

Total comments: 2

Patch Set 9 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -1 line) Patch
M gpu/config/software_rendering_list_json.cc View 1 2 3 4 5 6 7 8 2 chunks +93 lines, -1 line 0 comments Download

Messages

Total messages: 69 (38 generated)
ericrk
4 years, 6 months ago (2016-06-14 07:37:09 UTC) #3
ericrk
4 years, 6 months ago (2016-06-14 07:37:25 UTC) #4
vmiura
Let's add all of the IDs. 1 0x10de 0x08a0 MCP89 [GeForce 320M] 2 0x10de 0x08a3 ...
4 years, 6 months ago (2016-06-14 13:45:48 UTC) #7
vmiura
On 2016/06/14 13:45:48, vmiura wrote: > Let's add all of the IDs. > > 1 ...
4 years, 6 months ago (2016-06-14 13:58:51 UTC) #8
ericrk
Updated this to a more-conservative whitelist. Thanks!
4 years, 6 months ago (2016-06-20 23:45:17 UTC) #11
vmiura
LGTM.
4 years, 6 months ago (2016-06-21 01:02:14 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/60001
4 years, 6 months ago (2016-06-21 05:51:50 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/23833) ios-device-gn on ...
4 years, 6 months ago (2016-06-21 05:53:17 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/80001
4 years, 6 months ago (2016-06-21 17:41:49 UTC) #19
ericrk
+piman for owners. Thanks!
4 years, 6 months ago (2016-06-21 18:03:04 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/189048)
4 years, 6 months ago (2016-06-21 18:05:24 UTC) #23
piman
lgtm
4 years, 6 months ago (2016-06-21 18:18:35 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/100001
4 years, 6 months ago (2016-06-21 18:42:29 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/1412)
4 years, 6 months ago (2016-06-21 23:09:35 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/100001
4 years, 6 months ago (2016-06-21 23:12:13 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/140001
4 years, 6 months ago (2016-06-22 00:17:38 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/160001
4 years, 6 months ago (2016-06-22 00:38:51 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/1431)
4 years, 6 months ago (2016-06-22 05:16:51 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/180001
4 years, 6 months ago (2016-06-22 17:11:08 UTC) #42
ericrk
Moved this to a blacklist approach. This is what I was going to do for ...
4 years, 6 months ago (2016-06-22 17:26:58 UTC) #43
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 19:01:05 UTC) #45
ericrk
Removed the recently tested AMD R200 series, GeForce 7XX series and AMD HD7xxx/FireGL DXXX GPUs ...
4 years, 6 months ago (2016-06-23 22:09:32 UTC) #46
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/200001
4 years, 6 months ago (2016-06-23 22:10:46 UTC) #49
piman
lgtm
4 years, 6 months ago (2016-06-23 22:11:02 UTC) #50
vmiura
https://codereview.chromium.org/2066733003/diff/200001/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/2066733003/diff/200001/gpu/config/software_rendering_list_json.cc#newcode1109 gpu/config/software_rendering_list_json.cc:1109: "description": "Some GPUs on Mac can perform poorly with ...
4 years, 6 months ago (2016-06-23 22:39:24 UTC) #51
ericrk
https://codereview.chromium.org/2066733003/diff/200001/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/2066733003/diff/200001/gpu/config/software_rendering_list_json.cc#newcode1109 gpu/config/software_rendering_list_json.cc:1109: "description": "Some GPUs on Mac can perform poorly with ...
4 years, 6 months ago (2016-06-23 22:58:40 UTC) #53
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/240001
4 years, 6 months ago (2016-06-23 22:59:33 UTC) #58
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 01:43:18 UTC) #61
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2066733003/240001
4 years, 6 months ago (2016-06-24 18:41:29 UTC) #65
commit-bot: I haz the power
Committed patchset #9 (id:240001)
4 years, 6 months ago (2016-06-24 19:36:25 UTC) #67
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 19:37:36 UTC) #69
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/5033c4f6e97a466f03132ed2cbb655a8807e415c
Cr-Commit-Position: refs/heads/master@{#401933}

Powered by Google App Engine
This is Rietveld 408576698