|
|
Chromium Code Reviews
DescriptionThis change blacklists GPU rasterization for all GPUs on MacOS that have not had test coverage.
The GPUs which are not blacklisted are those from the following GPU series:
Intel: 6th and 7th Generation GPUs
NVidia: Geforce 7XX GPUs
NVidia: Geforce 6XX GPUs
ATI: R300 Series GPUs
ATI: R200 Series GPUs
ATI: HD 7XXX series GPUs
This gives us roughly 70% GPU Raster enablement on Mac.
BUG=614468, 613272
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/5033c4f6e97a466f03132ed2cbb655a8807e415c
Cr-Commit-Position: refs/heads/master@{#401933}
Patch Set 1 : Blacklist GPU raster on Geforce 320M #Patch Set 2 : Expand to be a whitelist (for M52) #Patch Set 3 : rebase #Patch Set 4 : remove extra comma #Patch Set 5 : remove multi_gpu_category from outer scope #Patch Set 6 : remove all multi_gpu_categories #Patch Set 7 : Move to blacklist #Patch Set 8 : Remove recently tested GPUs from blacklist #
Total comments: 2
Patch Set 9 : fix comment #Messages
Total messages: 69 (38 generated)
Description was changed from ========== Blacklist GPU raster on Geforce 320M Systems with a Geforce 320M perform fairly poorly with GPU raster. This change blacklists this GPU until more investigation can be done. BUG=614468,613272 ========== to ========== Blacklist GPU raster on Geforce 320M Systems with a Geforce 320M perform fairly poorly with GPU raster. This change blacklists this GPU until more investigation can be done. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
ericrk@chromium.org changed reviewers: + sievers@chromium.org
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Let's add all of the IDs. 1 0x10de 0x08a0 MCP89 [GeForce 320M] 2 0x10de 0x08a3 MCP89 [GeForce 320M] 3 0x10de 0x08a2 MCP89 [GeForce 320M] 4 0x10de 0x08a4 MCP89 [GeForce 320M]
On 2016/06/14 13:45:48, vmiura wrote: > Let's add all of the IDs. > > 1 0x10de 0x08a0 MCP89 [GeForce 320M] > 2 0x10de 0x08a3 MCP89 [GeForce 320M] > 3 0x10de 0x08a2 MCP89 [GeForce 320M] > 4 0x10de 0x08a4 MCP89 [GeForce 320M] I wonder if these are also related. 3 0x10de 0x0a29 GT216M [GeForce GT 330M] 4 0x10de 0x0a20 216 [GeForce GT 220] 5 0x10de 0x0a23 216 [GeForce 210] 6 0x10de 0x0a2d 216M [GeForce GT 320M]
Description was changed from ========== Blacklist GPU raster on Geforce 320M Systems with a Geforce 320M perform fairly poorly with GPU raster. This change blacklists this GPU until more investigation can be done. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change blacklists GPU rasterization for all GPUs on MacOS, then whitelists a set of known-good GPUs. The GPUs that are whitelisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs This gives us roughly 60% GPU Raster enablement on Mac. Additional testing/enablement is planned for: Intel: 8th generation GPUs NVidia: Geforce 7XX GPUs ATI: HD 7XXX series GPUs Which will bring this to 75%. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
ericrk@chromium.org changed reviewers: + vmiura@chromium.org
Updated this to a more-conservative whitelist. Thanks!
Description was changed from ========== This change blacklists GPU rasterization for all GPUs on MacOS, then whitelists a set of known-good GPUs. The GPUs that are whitelisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs This gives us roughly 60% GPU Raster enablement on Mac. Additional testing/enablement is planned for: Intel: 8th generation GPUs NVidia: Geforce 7XX GPUs ATI: HD 7XXX series GPUs Which will bring this to 75%. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change blacklists GPU rasterization for all GPUs on MacOS, then whitelists a set of known-good GPUs. The GPUs that are whitelisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs This gives us roughly 60% GPU Raster enablement on Mac. Additional testing/enablement is planned for: Intel: 5th and 8th generation GPUs NVidia: Geforce 7XX GPUs ATI: HD 7XXX series GPUs Which will bring this to 75%. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
LGTM.
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/80001
ericrk@chromium.org changed reviewers: + piman@chromium.org
+piman for owners. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2066733003/#ps100001 (title: "remove extra comma")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/100001
Patchset #5 (id:120001) has been deleted
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2066733003/#ps140001 (title: "remove multi_gpu_category from outer scope")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/140001
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2066733003/#ps160001 (title: "remove all multi_gpu_categories")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/160001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/180001
Moved this to a blacklist approach. This is what I was going to do for M53 anyway, and it should fix the issues we were hitting when switching GPUs.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Removed the recently tested AMD R200 series, GeForce 7XX series and AMD HD7xxx/FireGL DXXX GPUs from the blacklist.
Description was changed from ========== This change blacklists GPU rasterization for all GPUs on MacOS, then whitelists a set of known-good GPUs. The GPUs that are whitelisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs This gives us roughly 60% GPU Raster enablement on Mac. Additional testing/enablement is planned for: Intel: 5th and 8th generation GPUs NVidia: Geforce 7XX GPUs ATI: HD 7XXX series GPUs Which will bring this to 75%. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change blacklists GPU rasterization for all GPUs on MacOS, then whitelists a set of known-good GPUs. The GPUs that are whitelisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 7XX GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs ATI: R200 Series GPUs ATI: HD 7XXX series GPUs This gives us roughly 70% GPU Raster enablement on Mac. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/200001
lgtm
https://codereview.chromium.org/2066733003/diff/200001/gpu/config/software_re... File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/2066733003/diff/200001/gpu/config/software_re... gpu/config/software_rendering_list_json.cc:1109: "description": "Some GPUs on Mac can perform poorly with GPU rasterization. Disable all known NVidia GPUs other than the Geforce 6xx series, which has been tested.", Nit: 6xx and 7xx?
Patchset #9 (id:220001) has been deleted
https://codereview.chromium.org/2066733003/diff/200001/gpu/config/software_re... File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/2066733003/diff/200001/gpu/config/software_re... gpu/config/software_rendering_list_json.cc:1109: "description": "Some GPUs on Mac can perform poorly with GPU rasterization. Disable all known NVidia GPUs other than the Geforce 6xx series, which has been tested.", On 2016/06/23 22:39:24, vmiura wrote: > Nit: 6xx and 7xx? whoops... yup.. updated both comments.
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2066733003/#ps240001 (title: "fix comment")
The CQ bit was unchecked by ericrk@chromium.org
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066733003/240001
Description was changed from ========== This change blacklists GPU rasterization for all GPUs on MacOS, then whitelists a set of known-good GPUs. The GPUs that are whitelisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 7XX GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs ATI: R200 Series GPUs ATI: HD 7XXX series GPUs This gives us roughly 70% GPU Raster enablement on Mac. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change blacklists GPU rasterization for all GPUs on MacOS that have not had test coverage. The GPUs which are not blacklisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 7XX GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs ATI: R200 Series GPUs ATI: HD 7XXX series GPUs This gives us roughly 70% GPU Raster enablement on Mac. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ericrk@chromium.org
The CQ bit was unchecked by ericrk@chromium.org
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== This change blacklists GPU rasterization for all GPUs on MacOS that have not had test coverage. The GPUs which are not blacklisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 7XX GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs ATI: R200 Series GPUs ATI: HD 7XXX series GPUs This gives us roughly 70% GPU Raster enablement on Mac. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change blacklists GPU rasterization for all GPUs on MacOS that have not had test coverage. The GPUs which are not blacklisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 7XX GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs ATI: R200 Series GPUs ATI: HD 7XXX series GPUs This gives us roughly 70% GPU Raster enablement on Mac. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #9 (id:240001)
Message was sent while issue was closed.
Description was changed from ========== This change blacklists GPU rasterization for all GPUs on MacOS that have not had test coverage. The GPUs which are not blacklisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 7XX GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs ATI: R200 Series GPUs ATI: HD 7XXX series GPUs This gives us roughly 70% GPU Raster enablement on Mac. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change blacklists GPU rasterization for all GPUs on MacOS that have not had test coverage. The GPUs which are not blacklisted are those from the following GPU series: Intel: 6th and 7th Generation GPUs NVidia: Geforce 7XX GPUs NVidia: Geforce 6XX GPUs ATI: R300 Series GPUs ATI: R200 Series GPUs ATI: HD 7XXX series GPUs This gives us roughly 70% GPU Raster enablement on Mac. BUG=614468,613272 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/5033c4f6e97a466f03132ed2cbb655a8807e415c Cr-Commit-Position: refs/heads/master@{#401933} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/5033c4f6e97a466f03132ed2cbb655a8807e415c Cr-Commit-Position: refs/heads/master@{#401933} |
