Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 2066703004: Change fill-on-account-select to use Features API, not a custom flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fix tests on iOS Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc
index f2329995b2fa4a0818f17d8d222be4840236c0dc..9ddb0ef310eec12c6f2d83cf85d5251f4ede9cba 100644
--- a/components/password_manager/core/browser/password_form_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc
@@ -8,7 +8,7 @@
#include <memory>
#include <utility>
-#include "base/command_line.h"
+#include "base/feature_list.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
@@ -21,7 +21,6 @@
#include "components/autofill/core/browser/test_autofill_driver.h"
#include "components/autofill/core/browser/test_personal_data_manager.h"
#include "components/autofill/core/common/autofill_pref_names.h"
-#include "components/autofill/core/common/autofill_switches.h"
#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/credentials_filter.h"
#include "components/password_manager/core/browser/mock_password_store.h"
@@ -33,6 +32,7 @@
#include "components/password_manager/core/browser/statistics_table.h"
#include "components/password_manager/core/browser/stub_password_manager_client.h"
#include "components/password_manager/core/browser/stub_password_manager_driver.h"
+#include "components/password_manager/core/common/password_manager_features.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/pref_service.h"
@@ -688,8 +688,11 @@ class PasswordFormManagerFillOnAccountSelectTest
PasswordFormManagerFillOnAccountSelectTest() {}
void SetUp() override {
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- autofill::switches::kEnableFillOnAccountSelect);
+ std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
+ std::vector<const base::Feature*> enabled_features;
+ std::vector<const base::Feature*> disabled_features;
+ enabled_features.push_back(&features::kFillOnAccountSelect);
+ SetFeatures(enabled_features, disabled_features, std::move(feature_list));
PasswordFormManagerTest::SetUp();
}
};

Powered by Google App Engine
This is Rietveld 408576698