cc: Add frame data to LTHI tracing

cc/trees/layer_tree_host_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_impl.h"
 
 #include <algorithm>
 
 #include "base/basictypes.h"
+#include "base/containers/hash_tables.h"
 #include "base/json/json_writer.h"
 #include "base/metrics/histogram.h"
 #include "base/stl_util.h"
 #include "base/strings/stringprintf.h"
 #include "cc/animation/scrollbar_animation_controller.h"
 #include "cc/animation/timing_function.h"
 #include "cc/base/math_util.h"
 #include "cc/base/util.h"
 #include "cc/debug/debug_rect_history.h"
 #include "cc/debug/frame_rate_counter.h"
@@ skipping 397 matching lines @@
         render_surface->layer_list(),
         render_surface_layer->id(),
         render_surface->SurfacePropertyChangedOnlyFromDescendant(),
         render_surface->content_rect(),
         render_surface_layer->mask_layer(),
         render_surface_layer->filters(),
         render_surface_layer->filter().get());
   }
 }
 
+scoped_ptr<base::Value> LayerTreeHostImpl::FrameData::AsValue() const {
+  scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
+  scoped_ptr<base::ListValue> occluding_list(new base::ListValue());
+  for (size_t i = 0; i < occluding_screen_space_rects.size(); ++i) {
+    occluding_list->Append(MathUtil::AsValue(
+        occluding_screen_space_rects[i]).release());
+  }
+  value->Set("occluding_screen_space_rects", occluding_list.release());

[danakj, 2013/07/26 16:53:59]

These 3 lists only exist when you are showing them in the hud, I don't think
it's worth dumping debug data like this.

[piman, 2013/07/31 00:36:43]

Removed those (2) lists.

+  scoped_ptr<base::ListValue> non_occluding_list(new base::ListValue());
+  for (size_t i = 0; i < non_occluding_screen_space_rects.size(); ++i) {
+    non_occluding_list->Append(MathUtil::AsValue(
+        non_occluding_screen_space_rects[i]).release());
+  }
+  value->Set("non_occluding_screen_space_rects", non_occluding_list.release());
+  scoped_ptr<base::ListValue> render_pass_list(new base::ListValue());
+  for (size_t i = 0; i < render_passes.size(); ++i)
+    render_pass_list->Append(render_passes[i]->AsValue().release());
+  value->Set("render_passes", render_pass_list.release());
+  value->SetBoolean("contains_incomplete_tile", contains_incomplete_tile);
+  value->SetBoolean("has_no_damage", has_no_damage);
+  return value.PassAs<base::Value>();
+}
+
 void LayerTreeHostImpl::FrameData::AppendRenderPass(
     scoped_ptr<RenderPass> render_pass) {
   render_passes_by_id[render_pass->id] = render_pass.get();
   render_passes.push_back(render_pass.Pass());
 }
 
 static DrawMode GetDrawMode(OutputSurface* output_surface) {
   if (output_surface->ForcedDrawToSoftwareDevice()) {
     return DRAW_MODE_RESOURCELESS_SOFTWARE;
   } else if (output_surface->context3d()) {
@@ skipping 783 matching lines @@
           pending_tree_->root_layer(),
           base::Bind(&LayerTreeHostImplDidBeginTracingCallback));
     }
     LayerTreeHostCommon::CallFunctionForSubtree(
         active_tree_->root_layer(),
         base::Bind(&LayerTreeHostImplDidBeginTracingCallback));
   }
 
   TRACE_EVENT_OBJECT_SNAPSHOT_WITH_ID(
       TRACE_DISABLED_BY_DEFAULT("cc.debug"), "cc::LayerTreeHostImpl", this,
-      TracedValue::FromValue(AsValue().release()));
+      TracedValue::FromValue(AsValueWithFrame(frame).release()));

[danakj, 2013/07/26 16:53:59]

If frame->has_no_damage, you don't get here. Also if we checkerboard an
animation. I think you may want to dump this stuff in PrepareToDraw() so it
doesn't get missed by our early outs.

[piman, 2013/07/31 00:36:43]

For 2 reasons we want to leave it here:
1- we want to associate the frame with the LTHI state, so that we can show it in
the UI
2- we didn't want to add a separate track, and we can't have different types of
data in the same track

I raised your point and Nat agreed that we may want to dump the FrameData,
separately, when we don't draw, but as a separate category, and in a follow-up.

 
   // Because the contents of the HUD depend on everything else in the frame, the
   // contents of its texture are updated as the last thing before the frame is
   // drawn.
   if (active_tree_->hud_layer())
     active_tree_->hud_layer()->UpdateHudTexture(resource_provider_.get());
 
   if (output_surface_->ForcedDrawToSoftwareDevice()) {
     scoped_ptr<SoftwareRenderer> temp_software_renderer =
         SoftwareRenderer::Create(this, output_surface_.get(), NULL);
@@ skipping 1130 matching lines @@
 
 base::Time LayerTreeHostImpl::CurrentFrameTime() {
   UpdateCurrentFrameTime(&current_frame_timeticks_, &current_frame_time_);
   return current_frame_time_;
 }
 
 base::TimeTicks LayerTreeHostImpl::CurrentPhysicalTimeTicks() const {
   return base::TimeTicks::Now();
 }
 
-scoped_ptr<base::Value> LayerTreeHostImpl::AsValue() const {
+scoped_ptr<base::Value> LayerTreeHostImpl::AsValueWithFrame(
+    FrameData* frame) const {
   scoped_ptr<base::DictionaryValue> state(new base::DictionaryValue());
   if (this->pending_tree_)
       state->Set("activation_state", ActivationStateAsValue().release());
   state->Set("device_viewport_size",
              MathUtil::AsValue(device_viewport_size_).release());
   if (tile_manager_)
     state->Set("tiles", tile_manager_->AllTilesAsValue().release());
   state->Set("active_tree", active_tree_->AsValue().release());
   if (pending_tree_)
     state->Set("pending_tree", pending_tree_->AsValue().release());
+  if (frame)
+    state->Set("frame", frame->AsValue().release());
   return state.PassAs<base::Value>();
 }
 
 scoped_ptr<base::Value> LayerTreeHostImpl::ActivationStateAsValue() const {
   scoped_ptr<base::DictionaryValue> state(new base::DictionaryValue());
   state->Set("lthi", TracedValue::CreateIDRef(this).release());
   if (tile_manager_)
     state->Set("tile_manager", tile_manager_->BasicStateAsValue().release());
   return state.PassAs<base::Value>();
 }
 
 void LayerTreeHostImpl::SetDebugState(
     const LayerTreeDebugState& new_debug_state) {
   if (LayerTreeDebugState::Equal(debug_state_, new_debug_state))
     return;
   if (debug_state_.continuous_painting != new_debug_state.continuous_painting)
     paint_time_counter_->ClearHistory();
 
   debug_state_ = new_debug_state;
   SetFullRootLayerDamage();
 }
 
 }  // namespace cc