cc: Add frame data to LTHI tracing

cc/quads/draw_quad.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/quads/draw_quad.h"
 
 #include "base/logging.h"
+#include "base/values.h"
+#include "cc/base/math_util.h"
 #include "cc/quads/checkerboard_draw_quad.h"
 #include "cc/quads/debug_border_draw_quad.h"
 #include "cc/quads/io_surface_draw_quad.h"
 #include "cc/quads/picture_draw_quad.h"
 #include "cc/quads/render_pass_draw_quad.h"
 #include "cc/quads/solid_color_draw_quad.h"
 #include "cc/quads/stream_video_draw_quad.h"
 #include "cc/quads/texture_draw_quad.h"
 #include "cc/quads/tile_draw_quad.h"
 #include "cc/quads/yuv_video_draw_quad.h"
@@ skipping 65 matching lines @@
       break;
     case RENDER_PASS:  // RenderPass quads have their own copy() method.
     case INVALID:
       LOG(FATAL) << "Invalid DrawQuad material " << material;
       break;
   }
   copy_quad->shared_quad_state = copied_shared_quad_state;
   return copy_quad.Pass();
 }
 
+scoped_ptr<base::Value> DrawQuad::AsValue() const {
+  scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
+  value->SetInteger("material", material);
+  value->Set("transform", MathUtil::AsValue(
+      shared_quad_state->content_to_target_transform).release());
+  value->Set("rect", MathUtil::AsValue(rect).release());

[vmpstr, 2013/07/26 16:07:23]

Maybe the rects can be named something like "content_space_rect" or something to
indicate which space the rect is in. Alternatively they can just all be
transformed to target space before appending to value (which would also save
some calculations in the trace viewer).

[danakj, 2013/07/26 16:49:08]

Agree, content_rect is our typical nomenclature for such a thing.

[piman, 2013/07/31 00:36:43]

Following our discussion, and the need to have a pre-transformed version, I
chose new names: rect_in_content_space and rect_as_target_space_quad (the latter
is a "quad", aka 4 points because a rect is axis-aligned, property that doesn't
necessarily survive the transform). Ditto for opaque_rect and visible_rect.

Note: I also left the original (content space) rect, in case we want to show
things like the ratio of opaque vs transparent or things like that. Intersecting
quads is certainly less fun than intersecting axis-aligned rects.

+  value->Set("opaque_rect", MathUtil::AsValue(opaque_rect).release());
+  value->Set("visible_rect", MathUtil::AsValue(visible_rect).release());
+  value->Set("layer_content_bounds", MathUtil::AsValue(
+      shared_quad_state->visible_content_rect).release());
+  value->Set("layer_visible_content_rect", MathUtil::AsValue(
+      shared_quad_state->visible_content_rect).release());
+  value->SetBoolean("is_clipped", shared_quad_state->is_clipped);
+  value->Set("clip_rect",
+             MathUtil::AsValue(shared_quad_state->clip_rect).release());
+  value->SetBoolean("needs_blending", needs_blending);
+  value->SetDouble("opacity", shared_quad_state->opacity);
+  value->SetBoolean("ShouldDrawWithBlending()", ShouldDrawWithBlending());

[vmpstr, 2013/07/26 16:07:23]

should_draw_with_blending

[piman, 2013/07/31 00:36:43]

Done.

+  ExtendValue(value.get());
+  return value.PassAs<base::Value>();
+}
+
 }  // namespace cc