cc: Add frame data to LTHI tracing

cc/output/filter_operation.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
+#include "base/values.h"
 #include "cc/base/math_util.h"
 #include "cc/output/filter_operation.h"
 #include "third_party/skia/include/core/SkMath.h"
 
 namespace cc {
 
 bool FilterOperation::operator==(const FilterOperation& other) const {
   if (type_ != other.type_)
     return false;
   if (type_ == COLOR_MATRIX)
@@ skipping 193 matching lines @@
     blended_filter.set_drop_shadow_color(BlendSkColors(
         from_op.drop_shadow_color(), to_op.drop_shadow_color(), progress));
   } else if (to_op.type() == FilterOperation::ZOOM) {
     blended_filter.set_zoom_inset(std::max(
         BlendInts(from_op.zoom_inset(), to_op.zoom_inset(), progress), 0));
   }
 
   return blended_filter;
 }
 
+scoped_ptr<base::Value> FilterOperation::AsValue() const {
+  scoped_ptr<base::DictionaryValue> value(new DictionaryValue);
+  value->SetInteger("type", type_);
+  switch (type_) {

[vmpstr, 2013/07/26 16:07:23]

Can you add a default NOTREACHED() so that we catch any changes to the enums
(that a compiler might catch anyway)?

[danakj, 2013/07/26 16:49:08]

Actually, I'd prefer to not have a 'default' case so that we get compiler
warnings when things are added to the enum without being added here.

Having a DCHECK() that at least 1 case was run would be fine though.

+    case FilterOperation::GRAYSCALE:
+    case FilterOperation::SEPIA:
+    case FilterOperation::SATURATE:
+    case FilterOperation::HUE_ROTATE:
+    case FilterOperation::INVERT:
+    case FilterOperation::BRIGHTNESS:
+    case FilterOperation::CONTRAST:
+    case FilterOperation::OPACITY:
+    case FilterOperation::BLUR:
+    case FilterOperation::SATURATING_BRIGHTNESS:
+      value->SetDouble("amount", amount_);
+      break;
+    case FilterOperation::DROP_SHADOW:
+      value->SetDouble("std_deviation", amount_);
+      value->Set("offset", MathUtil::AsValue(drop_shadow_offset_).release());
+      value->SetInteger("color", drop_shadow_color_);
+      break;
+    case FilterOperation::COLOR_MATRIX: {
+      scoped_ptr<ListValue> matrix(new ListValue);
+      for (size_t i = 0; i < arraysize(matrix_); ++i)
+        matrix->AppendDouble(matrix_[i]);
+      value->Set("matrix", matrix.release());
+      break;
+    }
+    case FilterOperation::ZOOM:
+      value->SetDouble("amount", amount_);
+      value->SetDouble("inset", zoom_inset_);
+      break;
+  }
+  return value.PassAs<base::Value>();
+}
+
 }  // namespace cc