remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java - Issue 2066683003: [Chromoting] Add InputInjector and InputInjectorWrapper for easy unittesting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

Issue 2066683003: [Chromoting] Add InputInjector and InputInjectorWrapper for easy unittesting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/cardboard/Cursor.java ('k') | remoting/android/java/src/org/chromium/chromoting/jni/Client.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java b/remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

index 7800b4ef2da9180708bbdbc02ff8e9e0a0ca41c1..e5ac3babc693be38ff369292a238441a2f1fd178 100644

--- a/remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

+++ b/remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

@@ -14,8 +14,8 @@ import android.speech.SpeechRecognizer;

import com.google.vrtoolkit.cardboard.CardboardActivity;

import com.google.vrtoolkit.cardboard.CardboardView;

+import org.chromium.chromoting.InputStub;

import org.chromium.chromoting.R;

-import org.chromium.chromoting.TouchInputHandler;

import org.chromium.chromoting.jni.Client;

import java.util.ArrayList;

@@ -80,9 +80,9 @@ public class DesktopActivity extends CardboardActivity {

if (mRenderer.isLookingAtDesktop()) {

PointF coordinates = mRenderer.getMouseCoordinates();

mClient.sendMouseEvent((int) coordinates.x, (int) coordinates.y,

- TouchInputHandler.BUTTON_LEFT, true);

+ InputStub.BUTTON_LEFT, true);

mClient.sendMouseEvent((int) coordinates.x, (int) coordinates.y,

- TouchInputHandler.BUTTON_LEFT, false);

+ InputStub.BUTTON_LEFT, false);

} else {

if (mRenderer.isLookingFarawayFromDesktop()) {

getCardboardView().resetHeadTracker();