Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2066643002: Change the default result for CT Verification to "Not verified" (Closed)

Created:
4 years, 6 months ago by Ryan Sleevi
Modified:
4 years, 6 months ago
Reviewers:
estark, mattm
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the default result for CT Verification to "Not verified" When default constructing a CTVerifyResult, set the result to indicate that there were not enough SCTs. This matches a reasonable 'fail closed' implementation for CT status. BUG=none R=estark@chromium.org, mattm@chromium.org Committed: https://crrev.com/37be86cd32e1ccde5b193f53d7f568cf183880f9 Cr-Commit-Position: refs/heads/master@{#399594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/cert/ct_verify_result.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Ryan Sleevi
Emily: For your expert review Matt: For your OWNERS approval
4 years, 6 months ago (2016-06-13 22:20:58 UTC) #1
estark
lgtm
4 years, 6 months ago (2016-06-13 22:30:05 UTC) #2
mattm
lgtm
4 years, 6 months ago (2016-06-13 22:34:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066643002/1
4 years, 6 months ago (2016-06-13 22:36:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 23:18:23 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 23:21:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37be86cd32e1ccde5b193f53d7f568cf183880f9
Cr-Commit-Position: refs/heads/master@{#399594}

Powered by Google App Engine
This is Rietveld 408576698